[vscode] Read args from keybindings #9126#9372
Merged
RomanNikitenko merged 1 commit intoeclipse-theia:masterfrom Apr 21, 2021
Merged
[vscode] Read args from keybindings #9126#9372RomanNikitenko merged 1 commit intoeclipse-theia:masterfrom
RomanNikitenko merged 1 commit intoeclipse-theia:masterfrom
Conversation
| linux?: string; | ||
| win?: string; | ||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| args?: any; |
Contributor
There was a problem hiding this comment.
I created a PR to remove the duplicated interface #9374
Please remove this change.
Contributor
|
The changes look good to me! I added the example from the @xcariba |
Signed-off-by: Alexander Kozinko <xcariba@gmail.com>
RomanNikitenko
approved these changes
Apr 19, 2021
Contributor
|
I'm going to merge the PR in the evening if there are no objections |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What it does
Reads and stores args from keybindings field from package.json
How to test
Initialize a vscode extension following https://code.visualstudio.com/api/get-started/your-first-extension
Add a shortcut in extension's package.json:
Install extension.
Open text editor on any file, be shure that cursor is located somewhere in file and fire alt+7 in text editor.
It should insert "test" text on selection.
Review checklist
Reminder for reviewers