Skip to content

Remove duplicated Keybinding interface#9374

Merged
RomanNikitenko merged 1 commit intomasterfrom
removeDuplicate
Apr 19, 2021
Merged

Remove duplicated Keybinding interface#9374
RomanNikitenko merged 1 commit intomasterfrom
removeDuplicate

Conversation

@RomanNikitenko
Copy link
Contributor

@RomanNikitenko RomanNikitenko commented Apr 19, 2021

Signed-off-by: Roman Nikitenko rnikiten@redhat.com

What it does

Remove duplicated interface, please see here
The interface was provided within #8870

How to test

It's code clean up, I don't bring a new functionality.

Review checklist

Reminder for reviewers

Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
@RomanNikitenko
Copy link
Contributor Author

@vinokurig
I guess the interface was added by mistake, could you confirm that?

Copy link
Member

@paul-marechal paul-marechal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, definitely a mistake that is safe to remove :)

@RomanNikitenko RomanNikitenko marked this pull request as ready for review April 19, 2021 16:17
@vince-fugnitto vince-fugnitto added quality issues related to code and application quality vscode issues related to VSCode compatibility labels Apr 19, 2021
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@RomanNikitenko RomanNikitenko merged commit df062f6 into master Apr 19, 2021
@RomanNikitenko RomanNikitenko deleted the removeDuplicate branch April 19, 2021 18:35
@github-actions github-actions bot added this to the 1.13.0 milestone Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

quality issues related to code and application quality vscode issues related to VSCode compatibility

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants