ju/ednx/JU-11_P2: Add REGISTRATION_EXTRA_FIELDS to extra_fields - #463
Merged
Conversation
mariajgrimaldi
marked this pull request as ready for review
December 1, 2020 16:11
felipemontoya
approved these changes
Dec 1, 2020
mariajgrimaldi
force-pushed
the
ju/ednx/JU-11_P2
branch
from
December 2, 2020 23:07
9a94650 to
84b0ceb
Compare
mariajgrimaldi
force-pushed
the
ju/ednx/JU-11_P2
branch
from
December 3, 2020 22:49
84b0ceb to
0899414
Compare
andrey-canon
approved these changes
Dec 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a continuation of #458
Description and justification
This change was done to be able to add extra fields without saving them as
extended_profile_fields.For example, say that we want to add a Confirmation Password field, the purpose of this field is to confirm the password so we don't need to save it.
To create these fields we only have to add them to:
REGISTRATION_EXTRA_FIELDSandREGISTRATION_FIELD_ORDER