JU-11 Add the ability to customize the registration fields - #580
Merged
Conversation
magajh
force-pushed
the
li/ednx/JU-11
branch
from
November 16, 2021 18:50
79355c1 to
02c0e7b
Compare
magajh
requested review from
MaferMazu,
MoisesGSalas,
jignaciopm,
johanseto and
mariajgrimaldi
and removed request for
MaferMazu,
MoisesGSalas,
jignaciopm,
johanseto and
mariajgrimaldi
November 16, 2021 19:00
| """ | ||
| custom_fields = getattr(settings, "EDNX_CUSTOM_REGISTRATION_FIELDS", []) | ||
| for field in custom_fields: | ||
| if field.get("name") == field_name: |
Contributor
There was a problem hiding this comment.
what if we made this case insensitive? :thinking
Contributor
Author
There was a problem hiding this comment.
@mariajgrimaldi I'm curious as to why do you think that would be useful?
Contributor
There was a problem hiding this comment.
{
"label": "Celular",
"name": "mobile",
"type": "text"
}
==
{
"label": "Celular",
"name": "Mobile",
"type": "text"
}
Contributor
Author
There was a problem hiding this comment.
@mariajgrimaldi you're right, I'm changing it. Thankss for the suggestion
Contributor
Author
There was a problem hiding this comment.
@mariajgrimaldi done. I also changed the EXTRA_FIELDS method to avoid duplicates and to also make sure that field_name is always lowercase. What do you think?
magajh
requested review from
MaferMazu,
MoisesGSalas,
jignaciopm and
johanseto
November 16, 2021 20:10
Contributor
|
can you add optional fields to your tests settings? |
mariajgrimaldi
approved these changes
Nov 17, 2021
MoisesGSalas
approved these changes
Nov 18, 2021
magajh
force-pushed
the
li/ednx/JU-11
branch
from
November 18, 2021 19:42
247ba42 to
0834a07
Compare
…and EDNX_CUSTOM_REGISTRATION_FIELDS
magajh
force-pushed
the
li/ednx/JU-11
branch
from
November 18, 2021 21:52
0834a07 to
b8a2599
Compare
This was referenced Nov 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature adds the ability to customize the registration form
IMPORTANT
There is a typo HERE that was fixed in this PR #583
Documentation
https://docs.google.com/document/d/1XpVO596QXbx6IAzo88jiHMxH08tCO3s-NXx85TWjrB0/edit
For further context about the implementation, you can refer to the PRs description from the Juniper migration, where the feature was added.
PRs from previous migration
#458
#463
#481
#494
Minor changes in the code for Lilac
six.text_type() --> str()isinstance( , six.string_types) --> isinstance(, str)Testing
Microsite settings