Skip to content

Added capability to ignore fields -in register form- when creating them - #481

Merged
mariajgrimaldi merged 1 commit into
masterfrom
MJG/ignore_register_fields
Jan 8, 2021
Merged

Added capability to ignore fields -in register form- when creating them #481
mariajgrimaldi merged 1 commit into
masterfrom
MJG/ignore_register_fields

Conversation

@mariajgrimaldi

@mariajgrimaldi mariajgrimaldi commented Jan 4, 2021

Copy link
Copy Markdown
Contributor

This PR avoids raising errors when:

  1. A field is added to REGISTRATION_EXTRA_FIELDS
  2. We aren't interested in creating its definition dictionary because we don't want to render the field. For that, we don't want to raise any errors to not cause noise in sentry.

This is done to cover a special case with authorized_email field.

Now, to ignore it we will have to add the setting EDNX_IGNORE_REGISTER_FIELDS : ["authorized_email"]

@mariajgrimaldi mariajgrimaldi changed the title Added capability to ignore fields when creating them Added capability to ignore fields -in register form- when creating them Jan 5, 2021
Comment thread lms/envs/common.py Outdated
@mariajgrimaldi
mariajgrimaldi force-pushed the MJG/ignore_register_fields branch from 8488bfe to a960ef7 Compare January 7, 2021 14:27
@mariajgrimaldi
mariajgrimaldi changed the base branch from ednx/juniper+edunext to master January 7, 2021 14:27
@mariajgrimaldi
mariajgrimaldi force-pushed the MJG/ignore_register_fields branch from a960ef7 to fe9c0d2 Compare January 7, 2021 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants