Skip to content

Added documentation for Otel metrics - #3040

Merged
JonasKunz merged 3 commits into
elastic:mainfrom
JonasKunz:otel-metric-docs
Mar 2, 2023
Merged

Added documentation for Otel metrics#3040
JonasKunz merged 3 commits into
elastic:mainfrom
JonasKunz:otel-metric-docs

Conversation

@JonasKunz

Copy link
Copy Markdown
Contributor

What does this PR do?

Adds the documentation for #2968 and #3014.

@ghost

ghost commented Mar 1, 2023

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview previewSnapshots

Expand to view the summary

Build stats

  • Start Time: 2023-03-02T08:27:48.356+0000

  • Duration: 3 min 19 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark tests.

  • run jdk compatibility tests : Run the JDK Compatibility tests.

  • run integration tests : Run the Agent Integration tests.

  • run end-to-end tests : Run the APM-ITs.

  • run windows tests : Build & tests on windows.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@JonasKunz
JonasKunz marked this pull request as ready for review March 1, 2023 13:34
@github-actions

github-actions Bot commented Mar 1, 2023

Copy link
Copy Markdown

/test

@JonasKunz
JonasKunz requested a review from a team March 1, 2023 13:35

@SylvainJuge SylvainJuge left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I mostly have a few suggestions for wording.

There is also a lot of "you", so I would suggest simplifying a bit to avoid duplication, also that's probably bothering me only because doing the same in French would imply that we try to be friends with the end-user, so I'm definitely biased.

Comment thread docs/api-opentelemetry.asciidoc Outdated
Comment thread docs/api-opentelemetry.asciidoc Outdated
Comment thread docs/api-opentelemetry.asciidoc Outdated
Comment thread docs/api-opentelemetry.asciidoc Outdated
Comment on lines -144 to -149
[float]
[[otel-metrics]]
===== Metrics
This bridge only supports the tracing API.
The Metrics API is currently not supported.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

Co-authored-by: SylvainJuge <syl20j@gmail.com>
@JonasKunz

Copy link
Copy Markdown
Contributor Author

Great suggestions, thanks!

@JonasKunz
JonasKunz enabled auto-merge (squash) March 2, 2023 08:28
@JonasKunz
JonasKunz merged commit cfa5f18 into elastic:main Mar 2, 2023
@SylvainJuge SylvainJuge mentioned this pull request Apr 12, 2023
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants