Remove event.dataset from logging integrations - #1365
Merged
Conversation
This data is already covered by `service.name` and it was causing problems in structlog, see hynek/structlog#186 (comment)
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
basepi
added a commit
to basepi/apm-agent-python
that referenced
this pull request
Oct 15, 2021
basepi
added a commit
to basepi/apm-agent-python
that referenced
this pull request
Oct 15, 2021
basepi
added a commit
that referenced
this pull request
Oct 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This data is already covered by
service.nameand it was causing problems in structlog, see hynek/structlog#186 (comment)Related issues
Ref #1352