Skip to content

Remove event.dataset from integration with elastic-apm - #69

Merged
basepi merged 3 commits into
elastic:masterfrom
basepi:eventdataset
Oct 14, 2021
Merged

Remove event.dataset from integration with elastic-apm#69
basepi merged 3 commits into
elastic:masterfrom
basepi:eventdataset

Conversation

@basepi

@basepi basepi commented Oct 14, 2021

Copy link
Copy Markdown
Contributor

Also removes python 3.5 support as we now test against elastic-apm @ master which doesn't support python 3.5.

Ref elastic/apm-agent-python#1365

@basepi basepi self-assigned this Oct 14, 2021
@ghost

ghost commented Oct 14, 2021

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-10-14T17:26:41.574+0000

  • Duration: 8 min 31 sec

  • Commit: 4622cdc

Test stats 🧪

Test Results
Failed 0
Passed 162
Skipped 0
Total 162

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@basepi

basepi commented Oct 14, 2021

Copy link
Copy Markdown
Contributor Author

/test

@sethmlarson sethmlarson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Validating dropping Python 3.5 by looking at our PyPI stats, we've received 0-1 downloads from Python 3.5 for the past while. Goodbye Python 3.5!

@basepi
basepi merged commit b83dedb into elastic:master Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants