Remove event.dataset from integration with elastic-apm - #69
Merged
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
Contributor
Author
|
/test |
sethmlarson
approved these changes
Oct 14, 2021
sethmlarson
left a comment
Contributor
There was a problem hiding this comment.
LGTM.
Validating dropping Python 3.5 by looking at our PyPI stats, we've received 0-1 downloads from Python 3.5 for the past while. Goodbye Python 3.5!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also removes python 3.5 support as we now test against
elastic-apm @ masterwhich doesn't support python 3.5.Ref elastic/apm-agent-python#1365