Migrate Jenkinsfile 2 GH Actions Workflow by reakaleek · Pull Request #1366 · elastic/apm-agent-ruby

reakaleek · 2023-02-20T09:02:56Z

What does this pull request do?

Partially migrates the Jenkinsfile to GH Actions.

The benchmark tests will be handled in a follow-up.
Opbeans update is migrated to Bump version with updatecli opbeans-ruby#171

ghost · 2023-02-20T09:43:26Z

🌐 Coverage report

Name	Metrics % (`covered/total`)	Diff
Packages	100.0% (`1/1`)	💚
Files	99.237% (`130/131`)	👍
Classes	99.237% (`130/131`)	👍
Lines	57.1% (`2469/4324`)	👍
Conditionals	100.0% (`0/0`)	💚

reakaleek · 2023-02-21T13:26:22Z

While debugging I noticed that there is a flaky test that would fail randomly on any matrix item with the following error:

  1) ElasticAPM::Metrics.collect_and_send when no samples calls callback
     Failure/Error: expect(callback).to_not receive(:call)

       (#<Proc:0x37c1688b@/app/spec/elastic_apm/metrics_spec.rb:25 (lambda)>).call(*(any args))
           expected: 0 times with any arguments
           received: 1 time with any arguments
     # ./spec/elastic_apm/metrics_spec.rb:102:in `block in ElasticAPM'
     # /usr/local/bundle/jruby/2.5.0/gems/webmock-3.18.1/lib/webmock/rspec.rb:37:in `block in /usr/local/bundle/jruby/2.5.0/gems/webmock-3.18.1/lib/webmock/rspec.rb'

samples:

but keep benchmarks in Jenkins. They will be handled in a follow-up

reakaleek · 2023-03-06T14:05:20Z

We have some failing tests, but I think they are not related to this PR. It's also failing on main in https://apm-ci.elastic.co/job/apm-agent-ruby/job/apm-agent-ruby-mbp/job/main/76/

v1v

LGTM, just a few comments

ghost · 2023-03-06T14:25:15Z

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2023-03-30T14:01:48.675+0000
Duration: 3 min 59 sec

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.
run benchmark tests : Run the benchmark test.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

reakaleek · 2023-03-06T18:55:19Z

run benchmark tests

…kflow # Conflicts: # .ci/.jenkins_exclude.yml

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>

v1v · 2023-03-24T16:39:58Z

@estolfo , would you mind reviewing it please? Do you happen to know when a new release will be done? So we can be part of the process to be sure things work nicely when running on GH actions?

Thanks

…kflow

Co-authored-by: Adrien Mannocci <adrien.mannocci@gmail.com>

* elastic/main: (30 commits) docs: remove kibana endpoint (elastic#1381) Update status badge (elastic#1379) Create single status check that can be set as required (elastic#1378) Remove jenkins related precommit hooks (elastic#1380) Migrate Jenkinsfile 2 GH Actions Workflow (elastic#1366) Migrate update specs to updatecli (elastic#1375) v4.6.2 Fixing Faraday::RackBuilder::StackLocked (elastic#1371) Fix jruby docker images (elastic#1367) Update reference to sinatra main (elastic#1373) Update release:update_branch task to reference branch 4.x Add missing docs reference v4.6.1 Add security options to docker containers (elastic#1356) Make sure http status code is set when Faraday Middleware is used (elastic#1368) Use composite action for updatecli workflow (elastic#1365) Fix sha source in updatecli update-specs.yml (elastic#1363) Add update-specs updatecli workflow (elastic#1359) use jruby user to run docker containers (elastic#1355) Close the read pipe at the right moment (elastic#1351) ...

reakaleek self-assigned this Feb 20, 2023

github-actions Bot added the agent-ruby label Feb 20, 2023

reakaleek mentioned this pull request Feb 20, 2023

Fix jruby docker images #1367

Merged

reakaleek mentioned this pull request Feb 23, 2023

Bump version with updatecli elastic/opbeans-ruby#171

Merged

reakaleek force-pushed the feature/migrate-jenksinfile-2-gh-actions-workflow branch from c8d567a to 2c40b54 Compare March 6, 2023 10:06

Convert Jenkinsfile to GH Actions Workflow

359520f

but keep benchmarks in Jenkins. They will be handled in a follow-up

reakaleek force-pushed the feature/migrate-jenksinfile-2-gh-actions-workflow branch from b2d2d51 to 359520f Compare March 6, 2023 13:56

reakaleek requested review from a team March 6, 2023 13:57

reakaleek marked this pull request as ready for review March 6, 2023 13:57

reakaleek commented Mar 6, 2023

View reviewed changes

Comment thread .github/workflows/release.yml

elastic deleted a comment Mar 6, 2023

v1v reviewed Mar 6, 2023

View reviewed changes

Comment thread .ci/.jenkins_ruby.yml

v1v reviewed Mar 6, 2023

View reviewed changes

Comment thread .ci/Jenkinsfile

v1v reviewed Mar 6, 2023

View reviewed changes

Comment thread .github/workflows/ci.yml

Add permissions

e533ac6

reakaleek added 3 commits March 6, 2023 15:26

Add permissions to workflows

74711d1

Alphabetical order

aba5e41

Move commonly used command to a script

d832575

reakaleek force-pushed the feature/migrate-jenksinfile-2-gh-actions-workflow branch from 4562c2e to 59413ca Compare March 6, 2023 15:05

Refactor matrix

860c5eb

reakaleek force-pushed the feature/migrate-jenksinfile-2-gh-actions-workflow branch from 59413ca to 860c5eb Compare March 6, 2023 15:09

reakaleek mentioned this pull request Mar 6, 2023

Add check-dependent-jobs action elastic/apm-pipeline-library#2126

Merged

reakaleek mentioned this pull request Mar 8, 2023

Use dockerhub images #1369

Closed

9 tasks

Merge branch 'main' into feature/migrate-jenksinfile-2-gh-actions-wor…

fde0ae8

…kflow # Conflicts: # .ci/.jenkins_exclude.yml

v1v reviewed Mar 8, 2023

View reviewed changes

Comment thread .github/workflows/run-matrix.yml

reakaleek marked this pull request as draft March 8, 2023 08:26

Update .github/workflows/run-matrix.yml

4e150ea

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>

v1v reviewed Mar 8, 2023

View reviewed changes

Comment thread .ci/Jenkinsfile

Remove sanity checks and DOCS_ONLY script

21fb88a

reakaleek mentioned this pull request Mar 8, 2023

Publish jruby images in dockerhub elastic/apm-pipeline-library#2125

Merged

Use github action instead of jq

d48c341

reakaleek requested a review from v1v March 8, 2023 14:16

reakaleek marked this pull request as ready for review March 8, 2023 14:16

v1v approved these changes Mar 8, 2023

View reviewed changes

reakaleek requested a review from gregkalapos March 8, 2023 19:11

reakaleek requested a review from estolfo March 21, 2023 10:54

Merge branch 'main' into feature/migrate-jenksinfile-2-gh-actions-wor…

ad0c4c0

…kflow

amannocci suggested changes Mar 30, 2023

View reviewed changes

Comment thread .github/workflows/ci.yml

Comment thread .github/workflows/release.yml Outdated

Update .github/workflows/release.yml

a916ef4

Co-authored-by: Adrien Mannocci <adrien.mannocci@gmail.com>

amannocci approved these changes Mar 30, 2023

View reviewed changes

v1v reviewed Apr 3, 2023

View reviewed changes

Comment thread .ci/Jenkinsfile Outdated

reakaleek added 4 commits April 3, 2023 09:33

Remove post directive

cffeaf6

Fix setup-git action

2fc7226

Use setup-ruby instead of docker image

06a8514

Use setup-ruby instead of docker image

f6fb96d

reakaleek merged commit 754270c into elastic:main Apr 3, 2023

reakaleek deleted the feature/migrate-jenksinfile-2-gh-actions-workflow branch April 3, 2023 08:46

This was referenced Apr 3, 2023

Create single status check that can be set as required #1378

Merged

Update status badge #1379

Merged

action: enable matrix testing (version, framework) #1320

Closed

Uh oh!

Conversation

reakaleek commented Feb 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this pull request do?

Uh oh!

ghost commented Feb 20, 2023 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🌐 Coverage report

Uh oh!

reakaleek commented Feb 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

reakaleek commented Mar 6, 2023

Uh oh!

Uh oh!

v1v left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ghost commented Mar 6, 2023 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💚 Build Succeeded

Build stats

🤖 GitHub comments

Uh oh!

reakaleek commented Mar 6, 2023

Uh oh!

Uh oh!

Uh oh!

v1v commented Mar 24, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

reakaleek commented Feb 20, 2023 •

edited

Loading

ghost commented Feb 20, 2023 •

edited by ghost

Loading

reakaleek commented Feb 21, 2023 •

edited

Loading

ghost commented Mar 6, 2023 •

edited by ghost

Loading