Skip to content

Bump version with updatecli - #171

Merged
reakaleek merged 5 commits into
elastic:mainfrom
reakaleek:feature/bump-with-updatecli
Apr 3, 2023
Merged

Bump version with updatecli#171
reakaleek merged 5 commits into
elastic:mainfrom
reakaleek:feature/bump-with-updatecli

Conversation

@reakaleek

@reakaleek reakaleek commented Feb 23, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Details

Move bump opbeans-ruby from elastic/apm-agent-ruby to the consumer

How to test

GIT_USER=ok \
GIT_EMAIL=ok@ok.com \
GITHUB_TOKEN=<personal-access-token>
updatecli -c .ci/bump-opbeans-ruby.yml diff

Related Issues

@reakaleek
reakaleek force-pushed the feature/bump-with-updatecli branch from 6fdfbf0 to 53a74b1 Compare February 23, 2023 13:09
@reakaleek
reakaleek requested review from a team February 23, 2023 13:11
@reakaleek reakaleek self-assigned this Feb 23, 2023
@reakaleek
reakaleek marked this pull request as ready for review February 23, 2023 13:12
v1v
v1v reviewed Feb 23, 2023
View reviewed changes
Comment thread .github/workflows/bump-opbeans-ruby.yml Outdated
reakaleek and others added 2 commits February 23, 2023 14:27
@reakaleek @v1v
Update .github/workflows/bump-opbeans-ruby.yml
9e4bc21 
Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
@reakaleek
fix
bec0171
v1v
v1v reviewed Feb 23, 2023
View reviewed changes
Comment thread .ci/bump-opbeans-ruby.yml Outdated
scmid: githubConfig
kind: shell
spec:
command: ./.ci/bump-gem.sh

@v1v v1v Feb 23, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question:

I wonder whether this step could be replaced by:

  • bumping the version in the Gemfile directly
  • then run a new target in charge of:
    • bundle update elastic-apm"
  • configure the .github/workjflows/bump-opbeans-ruby.yml to run within a ruby context https://github.com/ruby/setup-ruby

@reakaleek reakaleek Feb 23, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually had something similar. but I wasn't 100% sure about it.

I was not able to find anything in the documentation, but do you know if I can mark a target dependent on another target in updatecli?

@reakaleek reakaleek Feb 23, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume the command bundle update elastic-apm needs the Gemfile to be updated already?

@v1v v1v Feb 23, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think targets in the updatecli run sequentially

dependson is available for targets -> https://www.updatecli.io/docs/core/target/

@reakaleek reakaleek Feb 23, 2023 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.. I knew I saw it somewhere, but couldn't find it anymore.

@reakaleek reakaleek Feb 23, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/elastic/opbeans-ruby/pull/171/files/bec01713d36fa013fd1174dff276b4de5d336e8b..af3f812222f4add1dda53fba11c37032e704dc34

@reakaleek reakaleek mentioned this pull request Feb 23, 2023
Merged
@reakaleek
reakaleek requested a review from gregkalapos March 8, 2023 19:05
@v1v

v1v commented Mar 24, 2023

Copy link
Copy Markdown
Member

@estolfo , would you mind reviewing it please?

@reakaleek
reakaleek merged commit f8d66a1 into elastic:main Apr 3, 2023
@reakaleek
reakaleek deleted the feature/bump-with-updatecli branch April 3, 2023 08:46
@v1v v1v mentioned this pull request May 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@v1v v1v v1v approved these changes
@gregkalapos gregkalapos Awaiting requested review from gregkalapos

Assignees

@reakaleek reakaleek

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@reakaleek @v1v