Added support for receiving inferred span children as OTLP span links. - #185
Merged
Conversation
JonasKunz
marked this pull request as ready for review
November 29, 2023 09:16
Contributor
Author
|
We've discussed this in the APM agents weekly and decided to stay with the proposed |
kruskall
approved these changes
Nov 29, 2023
11 tasks
Contributor
|
@jackshirazi ran a program to test this and sent data to an APM Server BC5 in ESS; seeing the waterfall for the trace and the span: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #175. Span-Links received via OTLP with the attribute
elastic.is_childset totruewill be stored aschild.ids instead of links.This is currently in draft until naming discussions about the attribute are settled.
I've manually tested this PR with our inferred-spans Java Otel extension:
