Add Inferred spans extension - #47
Merged
Merged
Conversation
JonasKunz
commented
Nov 23, 2023
| @@ -0,0 +1,396 @@ | |||
| /* | |||
Contributor
Author
There was a problem hiding this comment.
This file has also been copied unchaged.
|
|
||
| void clear(); | ||
|
|
||
| public static <T extends Recyclable> ObjectPool<T> createRecyclable( |
Contributor
Author
There was a problem hiding this comment.
This method was the only change/addition in the pooling package, all other classes have been copied unchanged.
JonasKunz
commented
Nov 23, 2023
| import java.security.NoSuchAlgorithmException; | ||
| import java.util.EnumSet; | ||
|
|
||
| public class ResourceExtractionUtil { |
Contributor
Author
There was a problem hiding this comment.
This class also has been copied unchanged from the elastic apm agent
Contributor
Author
|
Related apm-data PR: apm-data/pull/185 |
SylvainJuge
reviewed
Nov 24, 2023
Multiple copyright headers
SylvainJuge
approved these changes
Jan 8, 2024
| result.fail(); | ||
| } | ||
| }); | ||
| // TODO: Replace with co.elastic.otel.util.ExecutorUtils |
Member
There was a problem hiding this comment.
[minor] why not do the change right now ?
Contributor
Author
There was a problem hiding this comment.
ExecutorUtils is not yet visible from here, because it is in the custom subproject. We'll need to move ExecutorUtils to a common project first.
Co-authored-by: SylvainJuge <763082+SylvainJuge@users.noreply.github.com>
# Conflicts: # gradle/libs.versions.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the inferred spans feature from the previous elastic-apm-agent as a standalone OTel-extension.
Closes #23. Autoconfiguration and a
README.mdas documentation will be added with #29 .The initial commit of this PR is an unchanged copy of all the files from the original profiling plugin, reformatted with
spotless. This should allow you to ignore this commit when reviewing to focus on the more relevant remainign diff.Below is a sample application on how this extension can be used and tested.
I've also used this example application to manually verify that the
backup diagnostic filesfeature works and the diagnostic files can be replayed.Sample app