Skip to content

[salesforce] Implement apex data stream for Salesforce#4410

Merged
kush-elastic merged 11 commits into
elastic:mainfrom
yug-rajani:package_salesforce_apex
Jan 11, 2023
Merged

[salesforce] Implement apex data stream for Salesforce#4410
kush-elastic merged 11 commits into
elastic:mainfrom
yug-rajani:package_salesforce_apex

Conversation

@yug-rajani

@yug-rajani yug-rajani commented Oct 6, 2022 •
edited by kush-elastic
Loading

Copy link
Copy Markdown
Contributor
  • Enhancement

What does this PR do?

  • Generated the skeleton of Salesforce integration package.
  • Added 1 data stream ( apex )
  • Added data collection logic.
  • Added the ingest pipelines.
  • Mapped fields according to the ECS schema and added Fields metadata in the appropriate yml files.
  • Added system test cases.
    apex-dashbaord-1 ndjson

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^7.13.0).

How to test this PR locally

  • Clone integrations repo.
  • Install elastic-package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/salesforce directory.
  • Run the following command to run tests.

elastic-package test

@yug-rajani yug-rajani self-assigned this Oct 6, 2022
@yug-rajani yug-rajani requested review from a team, kush-elastic and lalit-satapathy October 6, 2022 13:17
@yug-rajani yug-rajani added enhancement New feature or request Team:Service-Integrations Label for the Observability Service Integrations team Integration:salesforce Salesforce labels Oct 6, 2022
@elasticmachine

elasticmachine commented Oct 6, 2022

Copy link
Copy Markdown

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine

elasticmachine commented Oct 6, 2022 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-01-11T06:20:49.438+0000

  • Duration: 15 min 22 sec

Test stats 🧪

Test Results
Failed 0
Passed 18
Skipped 0
Total 18

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine

elasticmachine commented Oct 6, 2022 •
edited
Loading

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (3/3) 💚
Files 100.0% (3/3) 💚
Classes 100.0% (3/3) 💚
Methods 100.0% (39/39) 💚
Lines 96.963% (862/889) ❕
Conditionals 100.0% (0/0) 💚

@yug-rajani yug-rajani linked an issue Oct 10, 2022 that may be closed by this pull request
Create package for Salesforce integration #3940
Closed
8 tasks
kush-elastic
kush-elastic approved these changes Oct 18, 2022
View reviewed changes

@kush-elastic kush-elastic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@botelastic

botelastic Bot commented Dec 2, 2022

Copy link
Copy Markdown

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic Bot added the Stalled label Dec 2, 2022
@botelastic botelastic Bot removed the Stalled label Dec 13, 2022
@kush-elastic kush-elastic marked this pull request as ready for review December 13, 2022 12:36
@agithomas

agithomas commented Dec 20, 2022

Copy link
Copy Markdown
Contributor

@SubhrataK , can you please review the dashboard , especially the colors used to represent the chart?

agithomas
agithomas reviewed Jan 3, 2023
View reviewed changes
Comment thread packages/salesforce/data_stream/apex/fields/fields.yml
Comment thread packages/salesforce/data_stream/apex/fields/fields.yml
Comment thread packages/salesforce/data_stream/apex/fields/fields.yml
Comment thread packages/salesforce/data_stream/apex/fields/fields.yml Outdated
Comment thread packages/salesforce/data_stream/apex/fields/fields.yml
Comment thread packages/salesforce/data_stream/apex/fields/fields.yml
Comment thread packages/salesforce/data_stream/apex/fields/fields.yml Outdated
@kush-elastic kush-elastic requested a review from agithomas January 5, 2023 05:26
This was referenced Jan 5, 2023
Merged
Closed
agithomas
agithomas approved these changes Jan 9, 2023
View reviewed changes

@agithomas agithomas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kush-elastic kush-elastic merged commit a7e6278 into elastic:main Jan 11, 2023
@elasticmachine

elasticmachine commented Jan 11, 2023

Copy link
Copy Markdown

Package salesforce - 0.3.0 containing this change is available at https://epr.elastic.co/search?package=salesforce

@kush-elastic kush-elastic mentioned this pull request Apr 25, 2023
Merged
4 tasks
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@yug-rajani @kush-elastic
[salesforce] Implement apex data stream for Salesforce (elastic#4410)
ae8fbb9 
* Implement 'apex' data stream for Salesforce

* Add changelog entry

* Update README as per review comments, other minor changes

* Add pagination support

* Update Screenshot colors

* Address review comments

* Add additional pipeline test

Co-authored-by: kush-elastic <kush.rana@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@agithomas agithomas agithomas approved these changes
@lalit-satapathy lalit-satapathy Awaiting requested review from lalit-satapathy
+2 more reviewers
@kush-elastic kush-elastic kush-elastic approved these changes
@SubhrataK SubhrataK SubhrataK approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@yug-rajani yug-rajani

Labels

enhancement New feature or request Integration:salesforce Salesforce Team:Service-Integrations Label for the Observability Service Integrations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Create package for Salesforce integration

5 participants

@yug-rajani @elasticmachine @agithomas @kush-elastic @SubhrataK