Skip to content

[salesforce] Implement logout_stream data stream for Salesforce#5990

Merged
kush-elastic merged 3 commits into
elastic:mainfrom
kush-elastic:package_salesforce_logout_stream
May 2, 2023
Merged

[salesforce] Implement logout_stream data stream for Salesforce#5990
kush-elastic merged 3 commits into
elastic:mainfrom
kush-elastic:package_salesforce_logout_stream

Conversation

@kush-elastic

@kush-elastic kush-elastic commented Apr 25, 2023

Copy link
Copy Markdown
Contributor
  • Enhancement

What does this PR do?

  • Generated the skeleton of Salesforce integration package.
  • Added 1 data stream ( logout_stream )
  • Added data collection logic.
  • Added the ingest pipelines.
  • Mapped fields according to the ECS schema and added Fields metadata in the appropriate yml files.
  • Added system test cases.

Related issues

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^8.7.0).

How to test this PR locally

  • Clone integrations repo.
  • Install elastic-package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/salesforce directory.
  • Run the following command to run tests.

elastic-package test

@kush-elastic kush-elastic requested a review from a team as a code owner April 25, 2023 12:25
@kush-elastic kush-elastic marked this pull request as draft April 25, 2023 12:26
@elasticmachine

elasticmachine commented Apr 25, 2023 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-28T11:02:12.997+0000

  • Duration: 16 min 11 sec

Test stats 🧪

Test Results
Failed 0
Passed 34
Skipped 0
Total 34

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine

elasticmachine commented Apr 25, 2023 •
edited
Loading

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (6/6) 💚
Files 100.0% (6/6) 💚
Classes 100.0% (6/6) 💚
Methods 98.649% (73/74) 👍 0.262
Lines 96.27% (1368/1421) 👎 -0.023
Conditionals 100.0% (0/0) 💚

@kush-elastic kush-elastic marked this pull request as ready for review April 28, 2023 11:04
@kush-elastic kush-elastic requested a review from agithomas April 28, 2023 11:04
@kush-elastic kush-elastic self-assigned this Apr 28, 2023
@kush-elastic kush-elastic added enhancement New feature or request v8.7.0 Team:Service-Integrations Label for the Observability Service Integrations team Integration:salesforce Salesforce labels Apr 28, 2023
agithomas
agithomas approved these changes Apr 28, 2023
View reviewed changes

@agithomas agithomas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kush-elastic kush-elastic merged commit 8e5b5bb into elastic:main May 2, 2023
@elasticmachine

elasticmachine commented May 2, 2023

Copy link
Copy Markdown

Package salesforce - 0.7.0 containing this change is available at https://epr.elastic.co/search?package=salesforce

orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@kush-elastic
[salesforce] Implement logout_stream data stream for Salesforce (el…
de5b4a3 
…astic#5990)

* Salesforce integration package with logout_stream data stream

* Update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@agithomas agithomas agithomas approved these changes
+1 more reviewer
@milan-elastic milan-elastic milan-elastic approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@kush-elastic kush-elastic

Labels

enhancement New feature or request Integration:salesforce Salesforce Team:Service-Integrations Label for the Observability Service Integrations team v8.7.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kush-elastic @elasticmachine @agithomas @milan-elastic