[Salesforce] Add pagination support for login_rest and logout_rest data streams#4866
Conversation
🌐 Coverage report
|
|
Please complete the internal review. Send me a note once it is done |
We are not able to provide approval from the Elastic account. It seems like still, some access is missing for the Elastic GitHub integration repo. Hence we are not able to approve. We have raised an IT ticket for the same. |
You may consider cancelling the IT ticket created for this purpose as it is not needed at the moment . If you decide to proceed, kindly ensure atleast one of the Elastic team member performs the code review. |
Currently, only Kush has access, But when he raises the PR, others are not able to review it. So we need at least one more person who has the access to reviewers and approval. |
|
LGTM! Approved. ✅ |
|
Package salesforce - 0.2.1 containing this change is available at https://epr.elastic.co/search?package=salesforce |
…ta streams (elastic#4866) * Add pagination support for login_rest and logout_rest * Add Changelog entry
What does this PR do?
In the current Salesforce Integration, we don’t have pagination support for login-rest and logout-rest data streams. So if in any case, we have a response body with more than 2000 records, the next page is never called and the data will not be fetched.
Solution:
You can request the next batch of records using the provided URL with your instance and session information, and repeat until all records have been retrieved. These requests use
nextRecordsUrland don’t include any parameters. The final batch of records doesn’t have anextRecordsUrlfield and returntruevalue for fielddoneChecklist
changelog.ymlfile.Related issues
salesforcepackage foundation along withlogin_restdata stream #4261salesforcepackage foundation along withlogout_restdata stream #4323