Merged
Conversation
1. We no longer need references to make as we always use cmake 2. Use camelCase for variables in build.gradle 3. Don't require that BOOST_ROOT be an environment variable when building natively on Windows 4. Remove the last occurrence of $ML_KEEP_GOING
edsavage
reviewed
Jul 7, 2022
| commandLine shell | ||
| args '-c', "source ./set_env.sh && 3rd_party/dependency_report.sh --csv \"${outputs.files.singleFile}\"" | ||
| // TODO: this won't work on Windows outside of Git bash | ||
| args shellFlag, "${setEnv} && 3rd_party/dependency_report.sh --csv \"${outputs.files.singleFile}\"" |
Contributor
There was a problem hiding this comment.
I'm about to raise a PR which replaces this bash script with a portable cmake equivalent
Author
There was a problem hiding this comment.
We need to be careful with this - something in release manager calls 3rd_party/dependency_report.sh. Any new script needs to be added in parallel and then the old one only removed after release manager is changed over.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
building natively on Windows