[ML] Platform independent dependency report script#2350
[ML] Platform independent dependency report script#2350edsavage wants to merge 1 commit intoelastic:mainfrom
Conversation
build.gradle
Outdated
| environment makeEnvironment | ||
| commandLine shell | ||
| args '-c', "source ./set_env.sh && 3rd_party/dependency_report.sh --csv \"${outputs.files.singleFile}\"" | ||
| args shell_flag, "${set_env} && ${cmake} -D OUTPUT_FILE=\"${outputs.files.singleFile}\" -P 3rd_party/dependency_report.cmake" |
There was a problem hiding this comment.
TODO: change variables here to camel case once #2347 has been merged to main
There was a problem hiding this comment.
You should be able to merge main into this PR branch now to get the updates
build.gradle
Outdated
| environment makeEnvironment | ||
| commandLine shell | ||
| args '-c', "source ./set_env.sh && 3rd_party/dependency_report.sh --csv \"${outputs.files.singleFile}\"" | ||
| args shell_flag, "${set_env} && ${cmake} -D OUTPUT_FILE=\"${outputs.files.singleFile}\" -P 3rd_party/dependency_report.cmake" |
There was a problem hiding this comment.
You should be able to merge main into this PR branch now to get the updates
| # | ||
| # Usage: | ||
| # dependency_report.sh --csv <output_file> | ||
| # cmake -D OUTPUT_FILE=<output_file> -P dependency_report.cmake |
There was a problem hiding this comment.
Please keep the existing dependency_report.sh in parallel to this new script until we can move release manager over to the new script.
|
I think you should merge latest main into the PR branch because then the PR will show just the files changed in this PR. At the moment it's showing changes from other PRs that weren't merge clashes with main, so are completely unrelated. |
Yes, I rebased on main which has screwed up the log history a tad. I'll try to fix it.. |
Replace dependency_report.sh bash script with cmake script equivalent
edsavage
force-pushed
the
dependency_report_cmake_script
branch
from
6b4a5e1 to
0aca0f4
Compare
2 participants
Replace dependency_report.sh bash script with cmake script equivalent