Edit related_integrations field for custom rules in UI [classic] by joepeeples · Pull Request #5151 · elastic/security-docs

joepeeples · 2024-05-01T19:01:31Z

Important

Do not merge to main until after 8.14.0 release, maybe until 8.15 feature freeze. This is to avoid adding 8.15 features into previous versions' branches (since those branches would be cut from main).

Contributes to #5099 by adding a step for Related integrations in the rule creation docs.

Preview

Create a detection rule

Twin PR for serverless

https://github.com/elastic/staging-serverless-security-docs/pull/337

I'm expecting a conflict between this PR and Edit required_fields field for custom rules in UI [classic] #5287, since both PRs change the same lines in the same file. Will need to resolve by including both steps in the correct order that they appear in the UI (first Required fields, then Related integrations).

github-actions · 2024-05-01T19:01:44Z

A documentation preview will be available soon.

🔨 Buildkite builds
📚 HTML diff
📙 Preview page

Request a new doc build by commenting

Rebuild this PR: run docs-build
Rebuild this PR and all Elastic docs: run docs-build rebuild

_{run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.}

_{If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.}

https://github.com/elastic/staging-serverless-security-docs/pull/337

benironside

Left a few small suggestions for your consideration, overall 🆒 🆒 🆒

joepeeples · 2024-05-08T19:15:21Z

This PR is ready to merge, but I don't think I should yet. If I merge now, then main will contain changes that won't be available in stateful until the 8.15 Stack release. Normally that's OK, since main always equals the next minor release. BUT if someone needs to update the same files with changes for 8.14 Stack release, they'll end up merging to main and then backporting to 8.14 and that's a problem, because the backport will bring this PR's 8.15 changes into the 8.14 branch.... I think? Or maybe not, if the backport is able to cherry-pick only the new changes intended for 8.14, not any and all diffs between main and 8.14...

…337) * Add new step to all rule types * Revise step, use variable for URL * Mention type-ahead * Explain related integrations Also links to more info, and moves that info to a more generic location (no longer just prebuilt) * Apply changes from Ben's review Review from #5151

approksiu

LGTM!

maximpn

LGTM

joepeeples · 2024-07-03T18:14:41Z

We now have the 8.15 branch to backport into, so we're G2G.

* Add new step to all rule types * Mention type-ahead * Apply feedback from serverless twin PR https://github.com/elastic/staging-serverless-security-docs/pull/337 * Apply changes from Ben's review (cherry picked from commit 50c3806)

…c] (backport #5151) (#5503) * Edit related_integrations field for custom rules in UI [classic] (#5151) * Add new step to all rule types * Mention type-ahead * Apply feedback from serverless twin PR https://github.com/elastic/staging-serverless-security-docs/pull/337 * Apply changes from Ben's review (cherry picked from commit 50c3806) * Delete docs/serverless directory and its contents --------- Co-authored-by: Joe Peeples <joe.peeples@elastic.co> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

…lastic#337) * Add new step to all rule types * Revise step, use variable for URL * Mention type-ahead * Explain related integrations Also links to more info, and moves that info to a more generic location (no longer just prebuilt) * Apply changes from Ben's review Review from elastic#5151

Add new step to all rule types

708d737

joepeeples added Team: Detections/Response Detections and Response Feature: Rules Docset: ESS Issues that apply to docs in the Stack release v8.15.0 labels May 1, 2024

joepeeples self-assigned this May 1, 2024

joepeeples mentioned this pull request May 1, 2024

Edit related_integrations field for custom rules in UI and API #5099

Closed

joepeeples requested review from approksiu and maximpn May 1, 2024 19:37

joepeeples marked this pull request as ready for review May 1, 2024 19:37

joepeeples requested a review from a team as a code owner May 1, 2024 19:37

jpdjere self-requested a review May 3, 2024 08:21

joepeeples added 4 commits May 3, 2024 13:33

Mention type-ahead

f2cd74b

Merge branch 'main' into 5099-related-integrations-edit-classic

e96bd08

Merge branch 'main' into 5099-related-integrations-edit-classic

7576426

Apply feedback from serverless twin PR

6e047d0

https://github.com/elastic/staging-serverless-security-docs/pull/337

benironside reviewed May 7, 2024

View reviewed changes

Comment thread docs/detections/rules-ui-create.asciidoc Outdated

benironside reviewed May 7, 2024

View reviewed changes

Comment thread docs/detections/rules-ui-create.asciidoc Outdated

benironside reviewed May 7, 2024

View reviewed changes

Comment thread docs/detections/rules-ui-manage.asciidoc Outdated

benironside reviewed May 7, 2024

View reviewed changes

Apply changes from Ben's review

731bb12

benironside approved these changes May 7, 2024

View reviewed changes

Merge branch 'main' into 5099-related-integrations-edit-classic

5e94656

banderror removed the request for review from jpdjere May 28, 2024 12:06

joepeeples mentioned this pull request May 30, 2024

Edit required_fields field for custom rules in UI [classic] #5287

Merged

approksiu approved these changes Jun 12, 2024

View reviewed changes

maximpn approved these changes Jun 17, 2024

View reviewed changes

Merge branch 'main' into 5099-related-integrations-edit-classic

2cf0522

joepeeples merged commit 50c3806 into main Jul 3, 2024

mergify Bot mentioned this pull request Jul 3, 2024

[8.15] Edit related_integrations field for custom rules in UI [classic] (backport #5151) #5503

Merged

joepeeples deleted the 5099-related-integrations-edit-classic branch July 3, 2024 19:36

mergify Bot mentioned this pull request Jul 3, 2024

[8.15] Edit required_fields field for custom rules in UI [classic] (backport #5287) #5506

Merged

joepeeples mentioned this pull request Aug 5, 2024

What's new in 8.15 #5508

Closed

22 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Edit related_integrations field for custom rules in UI [classic]#5151

Edit related_integrations field for custom rules in UI [classic]#5151
joepeeples merged 8 commits into
mainfrom
5099-related-integrations-edit-classic

joepeeples commented May 1, 2024 •

edited

Loading

Uh oh!

github-actions Bot commented May 1, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

benironside left a comment

Uh oh!

joepeeples commented May 8, 2024 •

edited

Loading

Uh oh!

approksiu left a comment

Uh oh!

maximpn left a comment

Uh oh!

joepeeples commented Jul 3, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

joepeeples commented May 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Preview

Twin PR for serverless

Related

Uh oh!

github-actions Bot commented May 1, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

benironside left a comment

Choose a reason for hiding this comment

Uh oh!

joepeeples commented May 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

approksiu left a comment

Choose a reason for hiding this comment

Uh oh!

maximpn left a comment

Choose a reason for hiding this comment

Uh oh!

joepeeples commented Jul 3, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

joepeeples commented May 1, 2024 •

edited

Loading

joepeeples commented May 8, 2024 •

edited

Loading