Edit required_fields field for custom rules in UI [classic]#5287
Merged
Conversation
joepeeples
added
Team: Detections/Response
|
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
This was referenced May 30, 2024
joepeeples
marked this pull request as ready for review
May 30, 2024 20:54
natasha-moore-elastic
previously approved these changes
May 31, 2024
natasha-moore-elastic
left a comment
natasha-moore-elastic
left a comment
Contributor
There was a problem hiding this comment.
Looks good, just one small suggestion. 🚀
|
🚀 Built co-preview-docs successfully!
|
nikitaindik
self-requested a review
June 2, 2024 07:56
natasha-moore-elastic
previously approved these changes
Jun 3, 2024
nikitaindik
previously approved these changes
Jun 3, 2024
nikitaindik
left a comment
nikitaindik
left a comment
Contributor
There was a problem hiding this comment.
Thank you @joepeeples! Changes LGTM.
joepeeples
dismissed stale reviews from natasha-moore-elastic and nikitaindik
via
July 3, 2024 20:10
2ab4676
benironside
approved these changes
Jul 3, 2024
|
🚀 Built elastic-dot-co-docs-preview-docs successfully!
|
mergify Bot
pushed a commit
that referenced
this pull request
Jul 3, 2024
* First draft: add step to rule procedures * Edit step (both serverless & classic) (cherry picked from commit ff8d574) # Conflicts: # docs/serverless/rules/rules-ui-create.mdx
joepeeples
added a commit
that referenced
this pull request
Jul 3, 2024
…ackport #5287) (#5506) * Edit required_fields field for custom rules in UI [classic] (#5287) * First draft: add step to rule procedures * Edit step (both serverless & classic) (cherry picked from commit ff8d574) # Conflicts: # docs/serverless/rules/rules-ui-create.mdx * Delete docs/serverless directory and its contents --------- Co-authored-by: Joe Peeples <joe.peeples@elastic.co> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #5131.
Previews
Classic: Create a detection rule - There's a new step in every rule type procedure except for machine learning, which doesn't support the "required fields" feature.
Serverless: Click the link below, then navigate to the page above in the Serverless Security doc set.
Related