Skip to content

Update .gitignore generated by 'mix new' - #13871

Merged
josevalim merged 1 commit into
elixir-lang:mainfrom
frerich:drop-obsolete-gitignore
Sep 30, 2024
Merged

Update .gitignore generated by 'mix new'#13871
josevalim merged 1 commit into
elixir-lang:mainfrom
frerich:drop-obsolete-gitignore

Conversation

@frerich

@frerich frerich commented Sep 30, 2024

Copy link
Copy Markdown
Contributor

The .gitignore file would reference '/.fetch' files, which caused some confusion (cf.
https://elixir-lang.slack.com/archives/C03EPRA3B/p1727706411018609).

Some research suggests that these files are no longer generated as of commit 59b6e2e so let's stop mentioning them in the .gitignore, too.

The .gitignore file would reference '/.fetch' files, which caused some
confusion (cf.
https://elixir-lang.slack.com/archives/C03EPRA3B/p1727706411018609).

Some research suggests that these files are no longer generated as of
commit 59b6e2e so let's stop mentioning
them in the .gitignore, too.
@josevalim
josevalim merged commit a2012c2 into elixir-lang:main Sep 30, 2024
@josevalim

Copy link
Copy Markdown
Member

💚 💙 💜 💛 ❤️

@frerich
frerich deleted the drop-obsolete-gitignore branch September 30, 2024 15:04
@sabiwara

Copy link
Copy Markdown
Contributor

Shouldn't this be kept around a bit more, for projects that are created today on the latest version, but are meant to be supporting multiple versions?
This pattern might not be so rare for library authors.
Perhaps we could replace the comment by a TODO instead?

@josevalim

Copy link
Copy Markdown
Member

The projects created with Elixir 1.18 will have a requirement on Elixir ~> 1.18 anyway, so I think we are good. If someone wants to both downgrade the Elixir version AND change it via a dep, then they can add it back, although I think it may be quite rare. :)

rhcarvalho added a commit to rhcarvalho/gitignore that referenced this pull request Aug 2, 2026
Update Elixir.gitignore to match the upstream template for new Elixir projects.

https://github.com/elixir-lang/elixir/blob/a9021b1c8d932fd5cf2339e4536c5c9ef024003f/lib/mix/lib/mix/tasks/new.ex#L307-L331

Remove `.fetch` which was also removed upstream (elixir-lang/elixir#13871).

Preserve additional patterns added in github#2132, github#2611, and github#2872, adding comments to match the style of the rest of the file.
rhcarvalho added a commit to praialabs/phoenix that referenced this pull request Aug 4, 2026
Match Elixir upstream .gitignore template changes:
  - Update "3rd-party" to "third-party" in documentation comments (elixir-lang/elixir#8308)
  - Remove deprecated /.fetch entry and comment (elixir-lang/elixir#13871)
  - Move /tmp/ entry to appear above erl_crash.dump (elixir-lang/elixir#14439)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants