Skip to content

Add {prod, dev, whatever_enviroment}.secret.exs in Elixir/Phoenix - #2611

Merged
shiftkey merged 1 commit into
github:masterfrom
GusGA:master
Mar 11, 2018
Merged

Add {prod, dev, whatever_enviroment}.secret.exs in Elixir/Phoenix#2611
shiftkey merged 1 commit into
github:masterfrom
GusGA:master

Conversation

@GusGA

@GusGA GusGA commented Feb 24, 2018

Copy link
Copy Markdown
Contributor

Reasons for making this change:

The config/prod.secret.exs file by default contains sensitive data and you should not commit it into version control. But can exist other configurations in the development environment that should not be shared like every developer database configuration because could be annoying to the rest of the team

Links to documentation supporting these rule changes:

Phoenix documentation site Link

@GusGA GusGA changed the title Add {prod, dev, whatever_enviroment}.secret.exs Add {prod, dev, whatever_enviroment}.secret.exs in Elixir/Phoenix Feb 24, 2018
@shiftkey

Copy link
Copy Markdown
Member

@GusGA thanks!

@shiftkey
shiftkey merged commit 26bf484 into github:master Mar 11, 2018
@GusGA

GusGA commented Mar 12, 2018

Copy link
Copy Markdown
Contributor Author

To you, for letting me collaborate.

rhcarvalho added a commit to rhcarvalho/gitignore that referenced this pull request Aug 2, 2026
Update Elixir.gitignore to match the upstream template for new Elixir projects.

https://github.com/elixir-lang/elixir/blob/a9021b1c8d932fd5cf2339e4536c5c9ef024003f/lib/mix/lib/mix/tasks/new.ex#L307-L331

Remove `.fetch` which was also removed upstream (elixir-lang/elixir#13871).

Preserve additional patterns added in github#2132, github#2611, and github#2872, adding comments to match the style of the rest of the file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants