Skip to content

update submodule#412

Merged
lokax merged 2 commits into
eloqdata:mainfrom
lokax:yf-fix-hm-attach
Jan 7, 2026
Merged

update submodule#412
lokax merged 2 commits into
eloqdata:mainfrom
lokax:yf-fix-hm-attach

Conversation

@lokax

@lokax lokax commented Jan 7, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Chores
    • Updated internal dependencies.

✏️ Tip: You can customize this high-level summary in your review settings.

Copilot AI review requested due to automatic review settings January 7, 2026 07:49
@coderabbitai

coderabbitai Bot commented Jan 7, 2026

Copy link
Copy Markdown

Walkthrough

This PR updates the submodule reference for src/mongo/db/modules/eloq/data_substrate to point to a newer commit hash, transitioning from bc6852eec to 646d45d9e. No functional code modifications are included in this change.

Changes

Cohort / File(s) Change Summary
Submodule Reference Update
src/mongo/db/modules/eloq/data_substrate
Bumped commit pointer to newer version for data substrate module

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested labels

trigger-ci

Suggested reviewers

  • liunyl
  • yi-xmu

Poem

🐰 A hop and a bump, a commit so new,
The submodule takes a modernized queue,
No code was harmed in this gentle advance,
Just pointers that shimmy and submodules dance! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title is overly vague and generic, using non-descriptive terms that don't convey meaningful information about which submodule was updated or why. Specify which submodule was updated and include relevant context, e.g., 'Update data_substrate submodule to fix HM attachment' or similar.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f82b030 and 9d702b1.

📒 Files selected for processing (1)
  • src/mongo/db/modules/eloq/data_substrate
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: githubzilla
Repo: eloqdata/eloqdoc PR: 279
File: src/mongo/db/modules/eloq/CMakeLists.txt:54-55
Timestamp: 2025-11-28T10:55:21.020Z
Learning: In src/mongo/db/modules/eloq/CMakeLists.txt, the CMake options EXT_TX_PROC_ENABLED, FORK_HM_PROCESS, and STATISTICS are used by the data_substrate submodule build system and should be retained as configuration interface options.
📚 Learning: 2025-11-28T10:55:21.020Z
Learnt from: githubzilla
Repo: eloqdata/eloqdoc PR: 279
File: src/mongo/db/modules/eloq/CMakeLists.txt:54-55
Timestamp: 2025-11-28T10:55:21.020Z
Learning: In src/mongo/db/modules/eloq/CMakeLists.txt, the CMake options EXT_TX_PROC_ENABLED, FORK_HM_PROCESS, and STATISTICS are used by the data_substrate submodule build system and should be retained as configuration interface options.

Applied to files:

  • src/mongo/db/modules/eloq/data_substrate
🔇 Additional comments (1)
src/mongo/db/modules/eloq/data_substrate (1)

1-1: Verify submodule update compatibility with parent build configuration.

Submodule updates carry integration risk. Given that the data_substrate submodule build system depends on CMake options (EXT_TX_PROC_ENABLED, FORK_HM_PROCESS, and STATISTICS), please verify:

  1. Build compatibility: Confirm the updated submodule commit 646d45d9e is reachable and builds successfully with the parent repo's CMake configuration.
  2. Configuration retention: Verify that no CMake interface options were removed or renamed in the submodule that would break the build system.
  3. Rationale: Provide context on why this update is necessary (e.g., bug fixes, new features, dependency updates).
  4. Integration testing: Confirm end-to-end testing has been performed with the updated submodule to catch any cascading failures.

Based on learnings from prior work on this submodule integration, the listed CMake options are critical to the build system.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the data_substrate submodule to a newer commit, advancing it from bc6852eec935a3ffca5918e540a544f38e9a9d2f to 646d45d9e9da43c9ac5107df1ed23fc97fbfd763.

  • Updates the submodule pointer for data_substrate

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@lokax lokax changed the title update submod update submodule Jan 7, 2026
@lokax lokax merged commit ede59db into eloqdata:main Jan 7, 2026
2 checks passed
@lokax lokax deleted the yf-fix-hm-attach branch January 7, 2026 08:52
@coderabbitai coderabbitai Bot mentioned this pull request Mar 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants