Skip to content

eloqstore: remove write limit#375

Merged
xiexiaoy merged 2 commits into
mainfrom
low_pq
Jan 22, 2026
Merged

eloqstore: remove write limit#375
xiexiaoy merged 2 commits into
mainfrom
low_pq

Conversation

@xiexiaoy

@xiexiaoy xiexiaoy commented Jan 22, 2026

Copy link
Copy Markdown
Collaborator

eloqdata/eloqstore#302

Summary by CodeRabbit

  • Chores
    • Removed the configurable limit for concurrent writes; that setting is no longer available. Other configuration options remain unchanged.
    • Updated an internal component pointer with no functional or behavioral changes.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai

coderabbitai Bot commented Jan 22, 2026

Copy link
Copy Markdown

Walkthrough

Removed the eloq_store_max_concurrent_writes configuration flag and its initialization from the EloqStore config; updated the eloqstore submodule pointer. No new APIs or alternate concurrent-write handling introduced.

Changes

Cohort / File(s) Summary
EloqStore Configuration Flag Removal
store_handler/eloq_data_store_service/eloq_store_config.cpp
Deleted DEFINE_uint32(eloq_store_max_concurrent_writes, ...) and removed assignment to eloqstore_configs_.max_concurrent_writes in the EloqStoreConfig constructor.
Submodule Pointer Update
store_handler/eloq_data_store_service/eloqstore
Updated submodule reference from 37340d7... to ce2cd44... (no code changes in this diff).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • thweetkomputer
  • MrGuin

Poem

🐰 I hopped through flags both old and new,
I nudged a pointer, trimmed a view.
A write-count flag I set aside,
Now simpler paths for code to glide.
Tiny change — a carrot cheer, hooray! 🥕

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The description only provides a reference (eloqdata/eloqstore#302) without explaining the change or following the template structure with required sections. Fill out the PR description template with a clear explanation of the change, testing notes, and reference the issue using the correct format (fixes eloqdb/tx_service#issue_id).
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'eloqstore: remove write limit' directly and clearly describes the main change—removal of the write concurrency limit configuration flag.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch low_pq

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@xiexiaoy xiexiaoy requested a review from liunyl January 22, 2026 07:18
@xiexiaoy xiexiaoy merged commit ecb6998 into main Jan 22, 2026
4 checks passed
@xiexiaoy xiexiaoy deleted the low_pq branch January 22, 2026 10:07
thweetkomputer added a commit that referenced this pull request Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants