chore: update submodule eloqstore and add new parameters to eloq_store_config#370
Conversation
WalkthroughThis PR extends EloqStore's cloud storage capabilities by adding a new source file to the build configuration and introducing three configuration flags to manage cloud upload batching, request concurrency, and threading parameters. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@store_handler/eloq_data_store_service/eloq_store_config.cpp`:
- Around line 130-138: The help text for the flag DEFINE_uint32 named
eloq_store_max_upload_batch is misleading (it says "concurrency"); update its
description to reflect that it controls the maximum upload batch size per core
(e.g., "EloqStore max upload batch size per core") and ensure consistency with
nearby flags DEFINE_uint32(eloq_store_max_cloud_concurrency) and
DEFINE_uint32(eloq_store_cloud_request_threads) so operators see clear, distinct
meanings for batch size vs concurrency.
Here are some reminders before you submit the pull request
fixes eloqdb/tx_service#issue_id./mtr --suite=mono_main,mono_multi,mono_basicSummary by CodeRabbit
Release Notes
New Features
Chores
✏️ Tip: You can customize this high-level summary in your review settings.