Skip to content

chore: update submodule eloqstore and add new parameters to eloq_store_config#370

Merged
thweetkomputer merged 2 commits into
mainfrom
single_url_zc
Jan 19, 2026
Merged

chore: update submodule eloqstore and add new parameters to eloq_store_config#370
thweetkomputer merged 2 commits into
mainfrom
single_url_zc

Conversation

@thweetkomputer

@thweetkomputer thweetkomputer commented Jan 19, 2026

Copy link
Copy Markdown
Collaborator

Here are some reminders before you submit the pull request

  • Add tests for the change
  • Document changes
  • Reference the link of issue using fixes eloqdb/tx_service#issue_id
  • Reference the link of RFC if exists
  • Pass ./mtr --suite=mono_main,mono_multi,mono_basic

Summary by CodeRabbit

Release Notes

  • New Features

    • Introduced configuration parameters to control cloud storage upload batch sizes, request concurrency limits, and thread allocation for cloud operations.
  • Chores

    • Updated build configuration and project dependencies.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai

coderabbitai Bot commented Jan 19, 2026

Copy link
Copy Markdown

Walkthrough

This PR extends EloqStore's cloud storage capabilities by adding a new source file to the build configuration and introducing three configuration flags to manage cloud upload batching, request concurrency, and threading parameters.

Changes

Cohort / File(s) Summary
Build Configuration
store_handler/eloq_data_store_service/build_eloq_store.cmake
Adds cloud_storage_service.cpp to ELOQ_STORE_SOURCES list for compilation into eloqstore library.
Configuration Management
store_handler/eloq_data_store_service/eloq_store_config.cpp
Introduces three new global configuration flags (eloq_store_max_upload_batch, eloq_store_max_cloud_concurrency, eloq_store_cloud_request_threads) and corresponding fields in EloqStoreConfig struct initialized via constructor using flag-or-config pattern. Note: Duplicate initialization blocks detected for the same three fields.
Submodule Reference
store_handler/eloq_data_store_service/eloqstore
Updates eloqstore submodule pointer from bafb377d7061e315b01f86ba79a0eae81a3adfa1 to cd987d107cf6684e6cd031e5bb6c8a70479f4668.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • MrGuin
  • zhangh43

Poem

🐰 A cloud storage quest we now begin,
Three flags dance in—concurrency, threads spin!
With batching and threading, so swift and so keen,
The EloqStore now soars to clouds unseen! ☁️✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description only contains the template checklist with all items unchecked and provides no actual implementation details, context, or explanation of the changes made. Replace the template checklist with a substantive description explaining the purpose of the submodule update, the new parameters added, their use cases, and why they are needed before merging.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main changes: updating the eloqstore submodule and adding new parameters to eloq_store_config, matching the raw summary.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch single_url_zc

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@store_handler/eloq_data_store_service/eloq_store_config.cpp`:
- Around line 130-138: The help text for the flag DEFINE_uint32 named
eloq_store_max_upload_batch is misleading (it says "concurrency"); update its
description to reflect that it controls the maximum upload batch size per core
(e.g., "EloqStore max upload batch size per core") and ensure consistency with
nearby flags DEFINE_uint32(eloq_store_max_cloud_concurrency) and
DEFINE_uint32(eloq_store_cloud_request_threads) so operators see clear, distinct
meanings for batch size vs concurrency.

Comment thread store_handler/eloq_data_store_service/eloq_store_config.cpp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants