Skip to content

chore: adapt to eloqstore zero copy large value#489

Merged
thweetkomputer merged 5 commits into
mainfrom
eloqstore-zero_copy_large_value
Jun 9, 2026
Merged

chore: adapt to eloqstore zero copy large value#489
thweetkomputer merged 5 commits into
mainfrom
eloqstore-zero_copy_large_value

Conversation

@thweetkomputer

@thweetkomputer thweetkomputer commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

Here are some reminders before you submit the pull request

  • Add tests for the change
  • Document changes
  • Reference the link of issue using fixes eloqdb/tx_service#issue_id
  • Reference the link of RFC if exists
  • Pass ./mtr --suite=mono_main,mono_multi,mono_basic

Summary by CodeRabbit

  • Chores

    • Updated build infrastructure and dependencies.
  • Refactor

    • Optimized internal storage management modules.

@coderabbitai

coderabbitai Bot commented Jun 9, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

This PR updates the eloqstore build configuration and dependency. The CMake source list for building the eloqstore library is modified to include new compilation units and remove obsolete ones. Simultaneously, the eloqstore submodule reference is pinned to a newer commit version.

Changes

eloqstore Build Configuration and Dependency Update

Layer / File(s) Summary
CMake source compilation units
store_handler/eloq_data_store_service/build_eloq_store.cmake
ELOQ_STORE_SOURCES list adds global_registered_memory.cpp, io_string_buffer.cpp, mem_cached_page.cpp, and page_manager.cpp, while removing index_page_manager.cpp and mem_index_page.cpp.
eloqstore submodule commit pin
store_handler/eloq_data_store_service/eloqstore
Submodule is pinned to commit 110fb6d33f from previously pinned commit 81afbca.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • liunyl
  • MrGuin

🐰 A hop, a skip, a build so bright,
New sources added, old ones take flight,
eloqstore bumps to a version anew,
CMake and submodule dancing in tune!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is a checklist template with no actual content about the changes, missing specific details about what was adapted and why. Replace the checklist template with a substantive description explaining the changes, the motivation for the zero copy adaptation, and any breaking changes or migration steps required.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly and specifically summarizes the main change: updating the build to adapt to eloqstore's zero copy large value feature.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch eloqstore-zero_copy_large_value

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@thweetkomputer thweetkomputer changed the title chore: Adapt to eloqstore zero copy large value chore: adapt to eloqstore zero copy large value Jun 9, 2026
@thweetkomputer thweetkomputer merged commit 887e352 into main Jun 9, 2026
4 checks passed
@thweetkomputer thweetkomputer deleted the eloqstore-zero_copy_large_value branch June 9, 2026 12:51
@coderabbitai coderabbitai Bot mentioned this pull request Jun 17, 2026
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants