Skip to content

feat: adapt to eloqstore auto config credentials#422

Merged
thweetkomputer merged 1 commit into
mainfrom
feat-eloqstore-auto-config
Mar 2, 2026
Merged

feat: adapt to eloqstore auto config credentials#422
thweetkomputer merged 1 commit into
mainfrom
feat-eloqstore-auto-config

Conversation

@thweetkomputer

@thweetkomputer thweetkomputer commented Feb 28, 2026

Copy link
Copy Markdown
Collaborator

Here are some reminders before you submit the pull request

  • Add tests for the change
  • Document changes
  • Reference the link of issue using fixes eloqdb/tx_service#issue_id
  • Reference the link of RFC if exists
  • Pass ./mtr --suite=mono_main,mono_multi,mono_basic

Summary by CodeRabbit

  • New Features
    • Cloud storage credentials are now automatically detected by default, simplifying authentication.
    • A new configuration option lets operators disable automatic credential detection if desired.

@coderabbitai

coderabbitai Bot commented Feb 28, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e0abd00 and a2a2d81.

📒 Files selected for processing (3)
  • store_handler/eloq_data_store_service/build_eloq_store.cmake
  • store_handler/eloq_data_store_service/eloq_store_config.cpp
  • store_handler/eloq_data_store_service/eloqstore
🚧 Files skipped from review as they are similar to previous changes (1)
  • store_handler/eloq_data_store_service/eloqstore

Walkthrough

Added a cloud backend source to the EloqStore build, introduced a new flag and config field to control automatic cloud credential detection, and advanced the eloqstore submodule reference.

Changes

Cohort / File(s) Summary
Build configuration
store_handler/eloq_data_store_service/build_eloq_store.cmake
Added ${ELOQ_STORE_SOURCE_DIR}/src/storage/cloud_backend.cpp to ELOQ_STORE_SOURCES.
Cloud credentials configuration
store_handler/eloq_data_store_service/eloq_store_config.cpp
Added DEFINE_bool(eloq_store_cloud_auto_credentials, true, ...); populated eloqstore_configs_.cloud_auto_credentials from the flag or config reader during EloqStoreConfig init.
Submodule update
store_handler/eloq_data_store_service/eloqstore
Updated eloqstore submodule reference to a newer commit.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • lzxddz
  • liunyl

Poem

🥕 I hopped through code and found a cloud,
I nudged a file and added a shroud.
A flag to seek credentials on its own,
A submodule bumped, a newer tone.
Happy hops — the store now knows the zone!

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description contains only an empty checklist template without actual implementation details, issue references, or information about the changes made. Add meaningful description of changes, reference related issue(s), note any RFC, and confirm test suite results. The checklist items should be marked as completed, not left as a template.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title 'feat: adapt to eloqstore auto config credentials' directly and specifically summarizes the main change in the PR, which introduces auto credentials configuration support for eloqstore.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat-eloqstore-auto-config

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@store_handler/eloq_data_store_service/eloqstore`:
- Line 1: The PR references an unreachable submodule commit
3330d481ba5544fb4cf894ae852fe41256abeaed for the
eloq_store_cloud_auto_credentials change; update the submodule pointer in the
repository (via .gitmodules and the gitlink) to a reachable commit or a branch
HEAD in the submodule repo and run git submodule sync && git submodule update
--init --recursive to ensure the commit exists locally before merging. Also add
tests and docs for the new eloq_store_cloud_auto_credentials feature to satisfy
the PR checklist: create/enable mtr tests that cover the feature (so they pass
./mtr --suite=mono_main,mono_multi,mono_basic) and add a documentation entry
describing usage and configuration for eloq_store_cloud_auto_credentials.

ℹ️ Review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 65caaad and 02a847c.

📒 Files selected for processing (3)
  • store_handler/eloq_data_store_service/build_eloq_store.cmake
  • store_handler/eloq_data_store_service/eloq_store_config.cpp
  • store_handler/eloq_data_store_service/eloqstore

Comment thread store_handler/eloq_data_store_service/eloqstore Outdated
update

update

feat: adapt to eloqstore auto config oss credentials
@thweetkomputer thweetkomputer force-pushed the feat-eloqstore-auto-config branch from e0abd00 to a2a2d81 Compare March 2, 2026 10:33
@thweetkomputer thweetkomputer merged commit 225ad67 into main Mar 2, 2026
4 checks passed
@thweetkomputer thweetkomputer deleted the feat-eloqstore-auto-config branch March 2, 2026 10:38
lokax added a commit that referenced this pull request Mar 10, 2026
lokax added a commit that referenced this pull request Mar 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants