Implement a function to defer rendering via promise chaining#180
Closed
Implement a function to defer rendering via promise chaining#180
Conversation
| let deferred = Ember.RSVP.defer(); | ||
|
|
||
| Ember.run.later(() => { | ||
| if (!this.get('isDestroyed')) { |
Contributor
There was a problem hiding this comment.
this callback should not bet let run if the component has been destroyed. Instead on destroy, we should actually cancel this timer, and more importantly we should also cleanup/resolve the promise.
Otherwise we cause the component (and everything it references) to be retained until the timer finally fires, although we know it has been destroyed earlier.
Member
|
#169 has been updated, this is no longer needed |
xg-wang
pushed a commit
to xg-wang/ember-cli-fastboot
that referenced
this pull request
Nov 16, 2020
Allow html attributes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is #169 with the merge conflict resolved