-
Notifications
You must be signed in to change notification settings - Fork 159
Implement a function to defer rendering via promise chaining #180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| var chai = require('chai'); | ||
| var expect = chai.expect; | ||
| var RSVP = require('rsvp'); | ||
| var AddonTestApp = require('ember-cli-addon-tests').AddonTestApp; | ||
| var request = require('request'); | ||
| var get = RSVP.denodeify(request); | ||
|
|
||
| describe('async content via deferred content', function() { | ||
| this.timeout(300000); | ||
|
|
||
| var app; | ||
|
|
||
| before(function() { | ||
|
|
||
| app = new AddonTestApp(); | ||
|
|
||
| return app.create('async-content') | ||
| .then(function() { | ||
| return app.startServer({ | ||
| command: 'fastboot', | ||
| additionalArguments: ['--serve-assets'] | ||
| }); | ||
| }); | ||
| }); | ||
|
|
||
| after(function() { | ||
| return app.stopServer(); | ||
| }); | ||
|
|
||
| it('waits for async content when using `fastboot.deferRendering`', function() { | ||
| return get({ | ||
| url: 'http://localhost:49741/' | ||
| }) | ||
| .then(function(response) { | ||
| expect(response.body).to.contain('Async content: foo'); | ||
| }); | ||
| }); | ||
| }); |
20 changes: 20 additions & 0 deletions
20
tests/fixtures/async-content/app/components/async-content.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| import Ember from 'ember'; | ||
|
|
||
| export default Ember.Component.extend({ | ||
| fastboot: Ember.inject.service(), | ||
|
|
||
| init() { | ||
| this._super(...arguments); | ||
|
|
||
| let deferred = Ember.RSVP.defer(); | ||
|
|
||
| Ember.run.later(() => { | ||
| if (!this.get('isDestroyed')) { | ||
| this.set('setLater', 'foo'); | ||
| } | ||
| deferred.resolve() | ||
| }, 100); | ||
|
|
||
| this.get('fastboot').deferRendering(deferred.promise); | ||
| } | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| {{async-content}} |
1 change: 1 addition & 0 deletions
1
tests/fixtures/async-content/app/templates/components/async-content.hbs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Async content: {{setLater}} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this callback should not bet let run if the component has been destroyed. Instead on destroy, we should actually cancel this timer, and more importantly we should also cleanup/resolve the promise.
Otherwise we cause the component (and everything it references) to be retained until the timer finally fires, although we know it has been destroyed earlier.