Don't define posix macros that we don't support - #18337
Closed
sbc100 wants to merge 1 commit into
Closed
Conversation
For some reason we were using -1, but AFAICT these macros are expected to be undefined when not available. This change was original made in #9452.
Collaborator
Author
|
From https://pubs.opengroup.org/onlinepubs/000095399/ docs on unistd.h: |
Collaborator
Author
|
Not worth it actually.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While -1 is valid value for these, simply not defining them is perfectly acceptable and has the same meaning AFAICT. This makes the patch smaller, and also works for codebased that use
#ifdefThis change was original made in #9452.