Skip to content

Don't define posix macros that we don't support #18337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sbc100 wants to merge 1 commit into from
Closed

Don't define posix macros that we don't support #18337

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion system/lib/libc/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ Some changes have been made to the version that was taken from upstream, includi
* Backporting an operator-precedence warning fix from 6e76e1540fc58a418494bf5eb832b556f9c5763e in the upstream version.
* Switch to using the wasi `fd_write` syscall instead of `writev`.
* Simplify stdout stream handling: do not support seeking, terminal handling, etc., as it just increases code size and Emscripten doesn't have those features anyhow.
* Setting `_POSIX_REALTIME_SIGNALS` and `_POSIX_SPAWN` macros to -1, to exclude unsupported functions.
* Don't define `_POSIX_REALTIME_SIGNALS` and `_POSIX_SPAWN` macros, to exclude unsupported functions.

Copy log.c and log2.c from ealier version of musl which result in smaller
binary size since they do not rely data tables in log_data.c and log2_data.c.
Expand Down
8 changes: 1 addition & 7 deletions system/lib/libc/musl/include/unistd.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,8 +242,6 @@ pid_t gettid(void);

#ifndef __EMSCRIPTEN__
#define _POSIX_REALTIME_SIGNALS _POSIX_VERSION
#else
#define _POSIX_REALTIME_SIGNALS -1
#endif

#define _POSIX_REGEXP 1
Expand All @@ -252,8 +250,6 @@ pid_t gettid(void);

#ifndef __EMSCRIPTEN__
#define _POSIX_SPAWN _POSIX_VERSION
#else
#define _POSIX_SPAWN -1
#endif

#define _POSIX_VDISABLE 0
Expand All @@ -264,9 +260,7 @@ pid_t gettid(void);
#define _POSIX_THREAD_ATTR_STACKADDR _POSIX_VERSION
#define _POSIX_THREAD_ATTR_STACKSIZE _POSIX_VERSION
#define _POSIX_THREAD_PRIORITY_SCHEDULING _POSIX_VERSION
#ifdef __EMSCRIPTEN__
#define _POSIX_THREAD_CPUTIME -1
#else
#ifndef __EMSCRIPTEN__
#define _POSIX_THREAD_CPUTIME _POSIX_VERSION
#endif
#define _POSIX_TIMERS _POSIX_VERSION
Expand Down