make sure we don't overwrite any other settings when updating strategy#8
Merged
Conversation
Entire-Checkpoint: 12a0a03fd4aa
Soph
force-pushed
the
soph/preserve-local-settings
branch
from
January 6, 2026 13:59
25bdf38 to
5957258
Compare
dipree
approved these changes
Jan 7, 2026
alishakawaguchi
added a commit
that referenced
this pull request
May 20, 2026
CI lint: - escape U+200B literals (staticcheck ST1018) Real bugs (cursor[bot] + Copilot review): - loop: ctx-cancel mid-cmd.Run() now classifies as OutcomeCancelled instead of being counted as a turn failure and tripping OutcomePaused after two consecutive cancels (#1) - loop: save state before returning OutcomePaused so --continue resumes from a snapshot that includes the failing turn (#11) - investigate fix: wrap context.Canceled as SilentError so Ctrl+C during the fix session doesn't print a cobra usage banner (#2) - cmd: redact URL userinfo on the issue-link Source: line in both interactive and non-interactive paths (#5) - issuelink: redact URL userinfo across gh stderr (not just argv) so a token in --issue-link cannot leak via the error path (#10) - cmd: outcome-aware footer — "Investigation ended" + resume hint for paused/cancelled, "Investigation complete" + fix hint only for Quorum/Stalled (#6) - cmd: validate maxTurns/quorum bounds after settings/flag merge so a hand-edited negative max_turns or oversized quorum errors cleanly instead of silently stalling (#7) - issuelink: tolerate GitHub URL trailing segments (/pull/123/files, trailing slash) — the regex now anchors prefix and ignores tail (#13) - picker: don't print "Saved investigate config" before persistence; moved to the caller after SaveLocal succeeds (#14) - picker: guard pickerFormOverride with atomic.Pointer so parallel tests that swap the override don't race (#12) Docs: - settings/loop: fix stale "0 → 3" max_turns doc; default is 2 (#8/#9) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Entire-Checkpoint: b0135abeee0d
khaong
added a commit
that referenced
this pull request
May 24, 2026
Resolves conflict in go.mod: keeps the entireio/auth-go dependency added by 49dca72 (Integrate auth-go library) while taking the newer go-git/go-git/v6 and go-git/go-billy/v6 versions from main. While here, advance the auth-go pin from the pre-release commit v0.1.1-0.20260520123811-da94c52ef430 to the v0.3.3 release tag. The intermediate v0.3.x versions deliver three fixes the entire CLI's split-host (us.auth.entire.io issuer, entire.io data API) deployment depends on: v0.3.1 (auth-go #6): HTTP Basic Auth for the token-exchange grant — zitadel-oidc reads client credentials only from Authorization: Basic on this grant, not the form body. v0.3.2 (auth-go #7): default SubjectTokenType to :access_token — zitadel-oidc's STS validator handles :access_token / :refresh_token / :id_token but NOT :jwt, so the prior URI was silently rejected as "subject_token is invalid". v0.3.3 (auth-go #8): default Audience to Resource on the wire — zitadel-OIDC-backed servers reject token-exchange requests without an explicit `audience` form field with "invalid_target: audience is required". End-to-end verified against us.auth.entire.io: entire login, search, activity all succeed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running
entire enableagain it would rewrite the settings file potentially overwriting other settings not used/set during enable.