Skip to content

Test Harness and "entire enable --agent" bug fix - #9

Merged
Soph merged 4 commits into
mainfrom
soph/improve-test-repo-skill-harness
Jan 7, 2026
Merged

Test Harness and "entire enable --agent" bug fix#9
Soph merged 4 commits into
mainfrom
soph/improve-test-repo-skill-harness

Conversation

@Soph

@Soph Soph commented Jan 6, 2026

Copy link
Copy Markdown
Collaborator

While testing the latest changes with the test-repo skill it did run into some issues with recently made changes around tracking tool usage. It also found a bug that when using --agent with entire enable directly some parts of setup were skipped. This included the .gitignore setup.

Now both paths run the same setup steps and make sure everything is setup correctly.

@Soph
Soph requested a review from dipree January 6, 2026 14:46
@Soph
Soph merged commit e16ad54 into main Jan 7, 2026
3 checks passed
@Soph
Soph deleted the soph/improve-test-repo-skill-harness branch January 7, 2026 15:56
alishakawaguchi added a commit that referenced this pull request May 20, 2026
CI lint:
- escape U+200B literals (staticcheck ST1018)

Real bugs (cursor[bot] + Copilot review):
- loop: ctx-cancel mid-cmd.Run() now classifies as OutcomeCancelled
  instead of being counted as a turn failure and tripping OutcomePaused
  after two consecutive cancels (#1)
- loop: save state before returning OutcomePaused so --continue resumes
  from a snapshot that includes the failing turn (#11)
- investigate fix: wrap context.Canceled as SilentError so Ctrl+C during
  the fix session doesn't print a cobra usage banner (#2)
- cmd: redact URL userinfo on the issue-link Source: line in both
  interactive and non-interactive paths (#5)
- issuelink: redact URL userinfo across gh stderr (not just argv) so a
  token in --issue-link cannot leak via the error path (#10)
- cmd: outcome-aware footer — "Investigation ended" + resume hint for
  paused/cancelled, "Investigation complete" + fix hint only for
  Quorum/Stalled (#6)
- cmd: validate maxTurns/quorum bounds after settings/flag merge so a
  hand-edited negative max_turns or oversized quorum errors cleanly
  instead of silently stalling (#7)
- issuelink: tolerate GitHub URL trailing segments (/pull/123/files,
  trailing slash) — the regex now anchors prefix and ignores tail (#13)
- picker: don't print "Saved investigate config" before persistence;
  moved to the caller after SaveLocal succeeds (#14)
- picker: guard pickerFormOverride with atomic.Pointer so parallel
  tests that swap the override don't race (#12)

Docs:
- settings/loop: fix stale "0 → 3" max_turns doc; default is 2 (#8/#9)

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Entire-Checkpoint: b0135abeee0d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants