Skip to content

fix: make creating-skills explicitly invoke skill-creator via Skill tool - #16

Merged
ether-moon merged 1 commit into
mainfrom
skill-creator-integration
Apr 16, 2026
Merged

fix: make creating-skills explicitly invoke skill-creator via Skill tool#16
ether-moon merged 1 commit into
mainfrom
skill-creator-integration

Conversation

@ether-moon

@ether-moon ether-moon commented Apr 16, 2026

Copy link
Copy Markdown
Owner

Summary

  • creating-skills의 Workflow 섹션에서 skill-creator:skill-creator를 Skill tool로 명시적으로 호출하도록 수정
  • 수동적 표현("use when available")이 실제 Skill tool 호출로 이어지지 않는 문제 해결

Changes

  • Overview를 "single entry point" 역할로 재정의
  • "When skill-creator is available" → "Step 1: Invoke skill-creator"로 구조 변경
  • "If it exists, invoke it now via the Skill tool — do not skip this step" 명령형 지시 추가
  • Fallback 조건을 "not installed"로 명확화

Test Plan

  • creating-skills 스킬 트리거 후 skill-creator가 설치된 환경에서 Skill tool 호출이 실행되는지 확인
  • skill-creator 미설치 환경에서 standalone 워크플로우로 정상 fallback 되는지 확인

Summary by CodeRabbit

Release Notes

  • Documentation
    • Restructured skill creation guidance to prioritize the skill-creator tool as the primary workflow when available.
    • Added explicit guardrails and best practices throughout the creation process.
    • Defined clear fallback procedures for when the tool is unavailable.

The passive instruction ("use skill-creator when available") was not
triggering actual Skill tool invocation. Rewrote the Workflow section
to use imperative language that directs Claude to call the Skill tool
before doing any other work.
@coderabbitai

coderabbitai Bot commented Apr 16, 2026

Copy link
Copy Markdown
📝 Walkthrough

Walkthrough

The SKILL.md documentation was restructured to establish itself as the single entry point for skill creation. It now mandates checking for and invoking the skill-creator tool first when available, with explicit guardrails and fallback instructions for when the tool is not installed.

Changes

Cohort / File(s) Summary
Documentation Restructuring
plugins/skill-set/skills/creating-skills/SKILL.md
Reframed documentation flow to prioritize delegation to skill-creator tool as primary workflow, added guardrails for language/size rules and red flags, clarified fallback behavior when tool unavailable.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A rabbit hops through skills so grand,
Now SKILL.md takes command!
"Find skill-creator," we gently say,
Then hop the proper way.
When tools aren't here, we've got a plan—
Documentation by bunny clan! 🌟

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and clearly reflects the main change: making the creating-skills workflow explicitly invoke skill-creator via the Skill tool instead of passive references.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch skill-creator-integration

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
plugins/skill-set/skills/creating-skills/SKILL.md (1)

23-24: Consider replacing forward references with direct section links.

The phrases "see Skill Conventions below" and "see the checklist below" create forward references that require readers to scan down to find the content. This is a minor navigation friction point.

♻️ Suggested improvement for clearer navigation
-While following skill-creator's workflow, enforce these guardrails from this skill throughout:
-- **Language and size rules** — see Skill Conventions below
-- **Red flags** — see the checklist below
+While following skill-creator's workflow, enforce these guardrails from this skill throughout:
+- **Language and size rules** — see [Skill Conventions](`#skill-conventions`)
+- **Red flags** — see [Red Flags](`#red-flags---stop-immediately`) and [reference/checklist.md](reference/checklist.md)
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@plugins/skill-set/skills/creating-skills/SKILL.md` around lines 23 - 24,
Replace the forward-reference phrases in SKILL.md: "**Language and size rules —
see Skill Conventions below**" and "**Red flags — see the checklist below**"
with direct section links to the corresponding headers (e.g., replace with
"[Skill Conventions](`#skill-conventions`)" and "[Red flags
checklist](`#red-flags`)" or the exact header anchor names used in the file) so
readers can jump directly to those sections without scanning; update the two
lines in the SKILL.md content accordingly to use the link text matching the
actual section headings.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@plugins/skill-set/skills/creating-skills/SKILL.md`:
- Around line 23-24: Replace the forward-reference phrases in SKILL.md:
"**Language and size rules — see Skill Conventions below**" and "**Red flags —
see the checklist below**" with direct section links to the corresponding
headers (e.g., replace with "[Skill Conventions](`#skill-conventions`)" and "[Red
flags checklist](`#red-flags`)" or the exact header anchor names used in the file)
so readers can jump directly to those sections without scanning; update the two
lines in the SKILL.md content accordingly to use the link text matching the
actual section headings.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 29025c7f-a9a6-41aa-9320-de83465c8d75

📥 Commits

Reviewing files that changed from the base of the PR and between 4fa3abc and 73fa3a7.

📒 Files selected for processing (1)
  • plugins/skill-set/skills/creating-skills/SKILL.md

@ether-moon
ether-moon merged commit 4de2156 into main Apr 16, 2026
1 check passed
@ether-moon
ether-moon deleted the skill-creator-integration branch April 16, 2026 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant