Restore creating-skills content policies

[ether-moon]

Summary

• restore durable English artifact and user-language runtime policies for creating-skills
• protect provenance, untrusted frontmatter, and time-sensitive content at the policy gate
• add creator-present evaluation coverage and deterministic regression checks

Tests

• plugins/skill-set/tests/test-authoring-skills.sh
• plugins/skill-set/tests/run.sh

Summary by CodeRabbit

• Documentation

  • Clarified content-language policies for repository artifacts and runtime communication.
  • Added guidance for provenance, untrusted imported content, and time-sensitive information.
  • Strengthened creator delegation, validation, and acceptance requirements.

• Tests

  • Expanded checks for language separation, content reuse, provenance, policy enforcement, and delegated workflow validation.

[coderabbitai]

Warning

Review limit reached

@ether-moon, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 40 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 56bafb54-392d-48f9-be41-da5685a87232

📥 Commits

Reviewing files that changed from the base of the PR and between 0e1d8d1 and 005b78f.

📒 Files selected for processing (3)

• plugins/skill-set/evals/creating-skills/new-with-creator/graders/lifecycle.md
• plugins/skill-set/skills/creating-skills/reference/checklist.md
• plugins/skill-set/tests/test-authoring-skills.sh

📝 Walkthrough

Walkthrough

The PR adds durable repository-content policies, propagates English-artifact and Korean-runtime requirements through delegated skill creation, expands lifecycle acceptance criteria, and adds tests for policy wording and language verification.

Changes

Creating-skills policy enforcement

Layer / File(s)	Summary
Define durable content policies plugins/skill-set/skills/creating-skills/SKILL.md, plugins/skill-set/skills/creating-skills/reference/*	The orchestration contract and references define language separation, reuse provenance, untrusted imported content handling, and validation rules for time-sensitive content.
Enforce delegated language and lifecycle flow plugins/skill-set/evals/creating-skills/new-with-creator/prompt.md, plugins/skill-set/evals/creating-skills/new-with-creator/graders/lifecycle.md	The delegated contract and lifecycle grader require English repository artifacts, Korean runtime communication, delegated ownership, ordered inspection, artifact creation, evaluation preparation, reporting, and validation.
Validate policy propagation plugins/skill-set/tests/test-authoring-skills.sh	Assertions verify durable policy requirements and independently check runtime and repository artifact language requirements.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

• ether-moon/skill-set#16: Both strengthen the creating-skills orchestration and skill-creator delegation contract.
• ether-moon/skill-set#29: Both tighten the new-with-creator flow, lifecycle grader, and delegated authoring loop.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title is concise and accurately summarizes the main change: restoring creating-skills content policies.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch ether_karrot/restore-creating-skills-policies

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@plugins/skill-set/evals/creating-skills/new-with-creator/graders/lifecycle.md`:
- Line 6: The lifecycle contract in
plugins/skill-set/evals/creating-skills/new-with-creator/graders/lifecycle.md:6
must require English content for the positive and negative eval files and every
generated repository artifact, not only SKILL.md. Update the assertions in
plugins/skill-set/tests/test-authoring-skills.sh:127-132 to verify this
English-artifact requirement, or add an end-to-end fixture that checks artifact
language.

In `@plugins/skill-set/skills/creating-skills/reference/checklist.md`:
- Line 32: Update the language checklist item in the creating-skills reference
to require that all user-facing runtime outputs—including conversations,
reports, summaries, errors, warnings, status updates, prompts, and generated PR
comments—use the detected user language, while durable repository content
remains in English.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 39cf1437-2c5c-4a37-b143-5014ddabdf65

📥 Commits

Reviewing files that changed from the base of the PR and between 942a9bc and 0e1d8d1.

📒 Files selected for processing (6)

• plugins/skill-set/evals/creating-skills/new-with-creator/graders/lifecycle.md
• plugins/skill-set/evals/creating-skills/new-with-creator/prompt.md
• plugins/skill-set/skills/creating-skills/SKILL.md
• plugins/skill-set/skills/creating-skills/reference/checklist.md
• plugins/skill-set/skills/creating-skills/reference/structure.md
• plugins/skill-set/tests/test-authoring-skills.sh