Add aiohttp_evicted_sessions to HTTPSessionManager#3805
Open
cyc60 wants to merge 2 commits intoethereum:mainfrom
Open
Add aiohttp_evicted_sessions to HTTPSessionManager#3805cyc60 wants to merge 2 commits intoethereum:mainfrom
cyc60 wants to merge 2 commits intoethereum:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong?
Still receive
Unclosed client sessionmessagesDisconnect is already implemented.
Related to Issue #
#3524
Closes #
How was it fixed?
The issue is with evicted sessions — they cannot be force-closed from client code. They remain open for the duration of the request_timeout.
Added aiohttp_evicted_sessions to HTTPSessionManager to track currently open evicted sessions.
Disconnect should now look like this:
Todo:
Cute Animal Picture