Skip to content

Add aiohttp_evicted_sessions to HTTPSessionManager #3805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cyc60 wants to merge 2 commits into
base: main
Choose a base branch
from
+5 −0
Open

Add aiohttp_evicted_sessions to HTTPSessionManager #3805

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
958a11f
Add aiohttp_evicted_sessions to HTTPSessionManager
cyc60 Jan 28, 2026
b8e6d96
Add type annotation
cyc60 Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions tests/core/utilities/test_http_session_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -455,12 +455,14 @@ async def cache_uri_and_return_session(uri):
# last session remains in cache, all others evicted
cache_data = http_session_manager.session_cache._data
assert len(cache_data) == 1
assert len(http_session_manager.aiohttp_evicted_sessions) == 1
_key, cached_session = cache_data.popitem()
assert cached_session == all_sessions[-1]

# assert all evicted sessions were closed
await asyncio.sleep(_timeout_for_testing + 0.1)
assert all(session.closed for session in all_sessions[:-1])
assert len(http_session_manager.aiohttp_evicted_sessions) == 0

# -- teardown -- #

Expand Down
3 changes: 3 additions & 0 deletions web3/_utils/http_session_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ def __init__(
self.session_cache = SimpleCache(cache_size)
self.session_pool = ThreadPoolExecutor(max_workers=session_pool_max_workers)
self._explicit_session = explicit_session
self.aiohttp_evicted_sessions: set[ClientSession] = set()

@staticmethod
def get_default_http_endpoint() -> URI:
Expand Down Expand Up @@ -252,6 +253,7 @@ async def async_cache_and_return_session(
# just stored in the `evicted_sessions` dict. So we can kick off a future
# task to close them and it should be safe to pop out of the lock here.
evicted_sessions = list(evicted_items.values())
self.aiohttp_evicted_sessions.update(evicted_sessions)
for evicted_session in evicted_sessions:
self.logger.debug(
"Async session cache full. Session evicted from cache: %s",
Expand Down Expand Up @@ -329,6 +331,7 @@ async def _async_close_evicted_sessions(

for evicted_session in evicted_sessions:
await evicted_session.close()
self.aiohttp_evicted_sessions.remove(evicted_session)
self.logger.debug("Closed evicted async session: %s", evicted_session)

if any(not evicted_session.closed for evicted_session in evicted_sessions):
Expand Down