Update controller-gen to 0.4.6#205
Closed
ekarlso wants to merge 1 commit into
Closed
Conversation
This fixes #204 Signed-off-by: Endre Karlson <endre.karlson@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #205 +/- ##
=======================================
Coverage 66.83% 66.83%
=======================================
Files 2 2
Lines 205 205
=======================================
Hits 137 137
Misses 43 43
Partials 25 25 Continue to review full report at Codecov.
|
Collaborator
|
@sabre1041 ptal - this might relate to your projects too? |
| cd $$CONTROLLER_GEN_TMP_DIR ;\ | ||
| go mod init tmp ;\ | ||
| go get sigs.k8s.io/controller-tools/cmd/controller-gen@v0.4.1 ;\ | ||
| GO111MODULE=on go get github.com/minio/controller-tools/cmd/controller-gen@v0.4.6 ;\ |
Collaborator
There was a problem hiding this comment.
This seems to be a fork, can we go with the vanilla upstream @ https://github.com/kubernetes-sigs/controller-tools/releases?
Collaborator
|
Superseded by #221 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #204