Skip to content

Update controller-gen to 0.4.6 #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ekarlso wants to merge 1 commit into from
Closed

Update controller-gen to 0.4.6 #205

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ TAG_WITHOUT_PREFIX := $(shell echo $(TAG) | sed s/^v//)
IMG ?= quay.io/evryfs/github-actions-runner-operator:$(TAG)
GHCR_IMG ?= ghcr.io/evryfs/github-actions-runner-operator:${TAG}
# Produce CRDs that work back to Kubernetes 1.11 (no version conversion)
CRD_OPTIONS ?= "crd:trivialVersions=true"
CRD_OPTIONS ?= "crd:trivialVersions=true,maxDescLen=0,generateEmbeddedObjectMeta=true"

# Default bundle image tag
BUNDLE_IMG ?= quay.io/evryfs/github-actions-runner-operator-bundle:$(TAG)
Expand Down Expand Up @@ -91,7 +91,7 @@ ifeq (, $(shell which controller-gen))
CONTROLLER_GEN_TMP_DIR=$$(mktemp -d) ;\
cd $$CONTROLLER_GEN_TMP_DIR ;\
go mod init tmp ;\
go get sigs.k8s.io/controller-tools/cmd/controller-gen@v0.4.1 ;\
GO111MODULE=on go get github.com/minio/controller-tools/cmd/controller-gen@v0.4.6 ;\
Copy link
Copy Markdown
Collaborator

@davidkarlsen davidkarlsen Feb 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be a fork, can we go with the vanilla upstream @ https://github.com/kubernetes-sigs/controller-tools/releases?

rm -rf $$CONTROLLER_GEN_TMP_DIR ;\
}
CONTROLLER_GEN=$(GOBIN)/controller-gen
Expand Down
Loading