chore: remove netlify-cli from devDependencies#7216
Merged
Conversation
Josh-Cena
added
the
pr: maintenance
Josh-Cena
commented
Apr 20, 2022
| @@ -18378,12 +14879,7 @@ typedarray@^0.0.6: | |||
| resolved "https://registry.yarnpkg.com/typedarray/-/typedarray-0.0.6.tgz#867ac74e3864187b1d3d47d996a78ec5c8830777" | |||
| integrity sha512-/aCDEGatGvZ2BIk+HmLf4ifCJFwvKFNb9/JeZPMulfgFracn9QFcAf5GO8B/mweUjSoblS5In0cWhqpfs/5PQA== | |||
|
|
|||
| typescript@^3.9.10: | |||
Collaborator
Author
There was a problem hiding this comment.
This is the major motivation for this change.
The 3600 lines of lock file being removed is also a huge gain.
RDIL
reviewed
Apr 20, 2022
Contributor
RDIL
left a comment
RDIL
left a comment
There was a problem hiding this comment.
Spectacular - let’s fast track this if possible!
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site settings. |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-7216--docusaurus-2.netlify.app/ |
|
Size Change: +5 B (0%) Total Size: 799 kB ℹ️ View Unchanged
|
Collaborator
Author
|
For reference, the node_modules size decreased from |
1 task
Josh-Cena
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Netlify-cli has an incredible bundle size bloat: https://twitter.com/SidaChen63/status/1512969887274004482
Furthermore, it pulls in
typescript@3.9which under circumstances gets hoisted to the root and results in build errors. I hope this would fix it.Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Ran the
npx -p netlify-cli netlify devscript locally; still works