chore: upgrade dependencies#7232
Conversation
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site settings. |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-7232--docusaurus-2.netlify.app/ |
|
Size Change: +996 B (0%) Total Size: 803 kB
ℹ️ View Unchanged
|
|
The "critical dependency" error persists 🤔 |
| "dependencies": { | ||
| "babel-plugin-dynamic-import-node": "2.3.0", | ||
| "unified": "^9.2.2" | ||
| }, |
There was a problem hiding this comment.
I don't understand why this is needed here
There was a problem hiding this comment.
Because of the wrong hoisting order. We need the right versions of unified. See #6476 (comment)
There was a problem hiding this comment.
🤪
does it change anything to move this as devDependency instead?
There was a problem hiding this comment.
I mean, it was already in devDependency, how moving it to dependency changes anything?
Afaik it only impacts if you run yarn install --production ?
There was a problem hiding this comment.
Err, mostly to highlight that it's not there to actually do anything, but just to re-order hoisting. The problem is we don't have comments in package.json so you have to do weird stuff to give something semantics
Josh-Cena
added
tag: dependencies
pr: dependencies
3 participants
This PR also fixes the wrong version of
babel-plugin-dynamic-import-nodebeing hoisted after #7216. See #3734 for more details.