fix(copy_only backups): ignore copy_only backups when making the backup-chain - #59
Merged
Alex Irion (alexirion10) merged 6 commits intoMar 11, 2021
Conversation
'Error CS0854 An expression tree may not contain a call or invocation that uses optional arguments'
Martin Higgs (Martin11175)
approved these changes
Feb 18, 2021
Martin Higgs (Martin11175)
left a comment
Martin Higgs (Martin11175)
left a comment
There was a problem hiding this comment.
Looks reasonable to me! Might it be worth adding a quick docstring for the ignoreCopyOnlyBackups parameter explaining why someone might want to set it (beyond just "it ignores is_copy_only backups")?
…OnlyBackups` parameter
Alex Irion (alexirion10)
suggested changes
Feb 19, 2021
Alex Irion (alexirion10)
left a comment
Alex Irion (alexirion10)
left a comment
Contributor
There was a problem hiding this comment.
I think a better approach here is the SQL query, not filtering out is_copy_only, but instead returning an extra column "is_copy_only".
In C# code when we can filter out those results when building the backup chain
Alex Irion (alexirion10)
approved these changes
Feb 23, 2021
Aditya Niraula (AdityaNPL)
changed the title
Aditya Niraula (AdityaNPL)
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Edited SQL query to ignore
copy_onlybackups when creating the backup chainTested against a local MSSQL instance.
Created a normal Full backup and then a
copy_onlyFull backupChain started from the correct backup point and didn't contain any
copy_onlybackups