Skip to content

fix(copy_only backups): ignore copy_only backups when making the backup-chain #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Alex Irion (alexirion10) merged 6 commits into from
Mar 11, 2021
Merged

fix(copy_only backups): ignore copy_only backups when making the backup-chain #59

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
83d8b20
feat(ignore_copy_only_backups): Added in the option to ignore copy_on…
AdityaNPL Feb 16, 2021
7fd2853
fix(tests): resolving CS0854 error
AdityaNPL Feb 16, 2021
ad14a30
feat(ignore_copy_only_backups): Added a docstring for the `ignoreCopy…
AdityaNPL Feb 18, 2021
6294103
deprecate(copy_only): removing feature to choose to add copy_only bac…
AdityaNPL Feb 23, 2021
45a2404
Merge branch 'master' into feat/ignore_copy_only_backups
Kaneraz Mar 11, 2021
75c2c20
Merge branch 'master' into feat/ignore_copy_only_backups
alexirion10 Mar 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/SmoFacade/Database.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,15 @@ public List<BackupMetadata> RecentBackups()
"s.database_backup_lsn, s.checkpoint_lsn, s.[type] AS backup_type, s.server_name, s.recovery_model " +
"FROM msdb.dbo.backupset s " +
"INNER JOIN msdb.dbo.backupmediafamily m ON s.media_set_id = m.media_set_id " +
"WHERE s.last_lsn >= (SELECT MAX(last_lsn) FROM msdb.dbo.backupset WHERE [type] = 'D' and database_name = @dbName) " +
"AND s.database_name = @dbName ORDER BY s.backup_start_date DESC, backup_finish_date";
"WHERE s.last_lsn >= (" +
"SELECT MAX(last_lsn) FROM msdb.dbo.backupset " +
"WHERE [type] = 'D' " +
"AND database_name = @dbName " +
"AND is_copy_only = 0" +
") " +
"AND s.database_name = @dbName " +
"AND is_copy_only = 0" +
"ORDER BY s.backup_start_date DESC, backup_finish_date";

using var cmd = _server.SqlConnection.CreateCommand();
cmd.CommandText = query;
Expand Down