Skip to content

ci: trigger on merge_group so a merge queue can be enabled#726

Merged
wbarnha merged 1 commit into
claude/redis-async-client-and-cifrom
claude/ci-merge-queue-trigger
Jul 21, 2026
Merged

ci: trigger on merge_group so a merge queue can be enabled#726
wbarnha merged 1 commit into
claude/redis-async-client-and-cifrom
claude/ci-merge-queue-trigger

Conversation

@wbarnha

@wbarnha wbarnha commented Jul 21, 2026

Copy link
Copy Markdown
Member

Description

Makes master merge-queue-ready. A GitHub merge queue validates each candidate as a merge_group event, but the workflow only triggered on push / pull_request / release — so the required check job would never run for a queued PR and the queue would stall indefinitely. This adds the merge_group trigger:

on:
  push:
    branches: [master]
  pull_request:
    branches: [master]
  merge_group:          # <-- added
  release:
    types: [created]
  • No behaviour change for normal pushes/PRs.
  • The check job (needs: [lint, test-pytest], alls-green) is already the single aggregated required status a queue wants, and now runs on merge_group too.
  • The advisory jobs (test-integration, test-pypy, test-redis-integration) stay continue-on-error / out of the check gate, so they won't block the queue.

To actually turn the queue on (maintainer, repo settings — not doable from a PR)

Settings → Rules / Rulesets (or branch protection on master) → enable "Require merge queue" targeting master, with the required status check set to ✅ Ensure the required checks passing (the check job). Pick merge method / max batch size as desired. This PR is the prerequisite; the toggle itself is admin-only.

Top of the stacked chain (based on #725). YAML validated.

🤖 Generated with Claude Code


Generated by Claude Code

A GitHub merge queue validates each candidate as a `merge_group` event.  The
workflow only triggered on push / pull_request / release, so the required
`check` job would never run for queued PRs and the queue would stall.  Add the
`merge_group` trigger so `master` is ready for a merge queue once a maintainer
enables it in the repository rules.

No behaviour change for normal pushes/PRs; the advisory jobs (integration,
pypy) stay out of the required `check` gate.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HHPL4VFWQRQPpjR1gXSKyL
@wbarnha
wbarnha merged commit cf8c97f into claude/redis-async-client-and-ci Jul 21, 2026
@wbarnha
wbarnha deleted the claude/ci-merge-queue-trigger branch July 21, 2026 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant