ci: trigger on merge_group (bootstrap the merge queue)#727
Merged
Conversation
The merge queue is enabled on `master`, but the workflow did not trigger on `merge_group`, so the required `check` job never ran for queued candidates and merges would stall. Add the trigger directly on top of `master` so the queue becomes functional. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HHPL4VFWQRQPpjR1gXSKyL
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #727 +/- ##
=======================================
Coverage 94.15% 94.15%
=======================================
Files 104 104
Lines 11136 11136
Branches 1201 1201
=======================================
Hits 10485 10485
Misses 550 550
Partials 101 101 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Merge this first, directly onto
master, to un-stall the merge queue.The merge queue is enabled on
master, butmaster's CI workflow only triggers onpush/pull_request/release— notmerge_group. A queue validates each candidate as amerge_groupevent, so the requiredcheckjob never runs for queued PRs and merges stall. (The earlier trigger PR, #726, was based on the stacked chain and merged into that branch, notmaster, somasterstill lacks it.)This is the same 4-line
on:addition, but based directly onmasterso it can land without the whole chain:How to land it (chicken-and-egg)
Because "require merge queue" is on, the normal Merge button will try to queue this PR too — which would stall for the same reason. Break the loop one of two ways:
Once this is on
master, the queue is fully functional and everything else (including the stacked chain #716→#725) can go through it normally.🤖 Generated with Claude Code
Generated by Claude Code