-
Notifications
You must be signed in to change notification settings - Fork 272
feat(auth): Add QueryUsers API
#727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23723ce to
784ca1b
Compare
pashanka
approved these changes
Nov 28, 2025
jonathanedey
approved these changes
Dec 8, 2025
Collaborator
jonathanedey
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks!
Adds the `QueryUsers` function to the Auth client, allowing users to query for user accounts with various filters. - Defines `QueryUsersRequest` and `QueryUsersResponse` structs. - Implements the `QueryUsers` function to call the `accounts:query` endpoint. - Includes support for tenant-specific queries. - Adds comprehensive unit tests for the new functionality.
- Updates the `TestQueryUsersWithTenant` to create a tenant-specific client and verify the request URL. - Corrects the `QueryUsersRequest` struct to use `string` for `Limit` and `Offset` fields, and adds the `TenantID` field. - Updates the test cases to reflect the struct changes.
Moves the tenant-specific test for `QueryUsers` to `tenant_mgt_test.go` to follow the existing test structure. - Renames `TestQueryUsersWithTenant` to `TestTenantQueryUsers`. - Moves the test function to `auth/tenant_mgt_test.go`.
Renames the `SqlExpression` struct to `SQLExpression` to conform to Go's linting standards for acronyms. - Updates the struct definition in `auth/user_mgt.go`. - Updates all usages of the struct in `auth/user_mgt.go` and `auth/user_mgt_test.go`.
c3ff5f7 to
c9aefa0
Compare
Merged
lahirumaramba
added a commit
that referenced
this pull request
Jan 21, 2026
* chore: Added and `AGENTS.md` file to instruct AI agents how to interact with this repository (#710) * fix(auth): Fixed auth error code parsing (#712) * fix(auth): Fixed auth error code parsing * fix(auth): Fixed test to use error message prefix * chore: update copyright headers from Google Inc. to Google LLC (#713) * chore: Update github actions workflows and integration test resources (#740) * chore: Pinned github actions to a full-length commit SHA * chore: Update integration test resources * chore: Added environment label to release action * Trigger integration tests * feat(firestore): Added Firestore Multi Database Support (#733) * feat(firestore): Add Firestore Multi Database Support * fix: Address gemini review * fix: gemini review * fix: Update name from API review * fix: Address review comments * chore: Fix CONTRIBUTING.md typo Co-authored-by: Lahiru Maramba <llahiru@gmail.com> --------- Co-authored-by: Lahiru Maramba <llahiru@gmail.com> * feat(auth): Add `QueryUsers` API (#727) This change implements the accounts:query functionality, providing a new QueryUsers method that allows searching for users with filters and sorting options. RELEASE_NOTE: Added QueryUsers() API to support querying user accounts with filters, sorting, and pagination. * Update the release actions process (#741) This PR refactors the release automation to improve security by removing the direct merge from the workflow. * [chore] Release 4.19.0 (#742) * Revert "[chore] Release 4.19.0 (#742)" (#744) This reverts commit 3a86709. * chore: Update Release Workflows for Push triggers (#745) * chore: Update release actions to run on Release env * Trigger CI * update the actions * update the base_ref * remove fetch-depth to prevent conflicts * [chore] Release 4.19.0 Take 2 (#746) --------- Co-authored-by: Jonathan Edey <145066863+jonathanedey@users.noreply.github.com> Co-authored-by: Lahiru Maramba <llahiru@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change implements the
accounts:queryfunctionality, providing a newQueryUsersmethod that allows searching for users with filters and sorting options.RELEASE_NOTE: Added
QueryUsers()API to support querying user accounts with filters, sorting, and pagination.