Skip to content

feat(firestore): Added Firestore Multi Database Support #733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jonathanedey merged 7 commits into from
Jan 15, 2026
Merged

feat(firestore): Added Firestore Multi Database Support #733

jonathanedey merged 7 commits into from
Jan 15, 2026

Conversation

@jonathanedey
Copy link
Collaborator

@jonathanedey jonathanedey commented Dec 4, 2025

RELEASE NOTE: Added support for multiple Cloud Firestore named databases.

@jonathanedey jonathanedey added release-note release:stage Stage a release candidate labels Dec 4, 2025
@gemini-code-assist
Copy link

gemini-code-assist bot commented Dec 4, 2025

Summary of Changes

Hello @jonathanedey, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the Firestore client by introducing support for multiple named databases. It provides a new API method, FirestoreWithDatabase, allowing developers to specify a target database when initializing a Firestore client. This change is accompanied by thorough unit and integration tests to ensure the reliability and correct behavior of the new multi-database capabilities, facilitating more flexible and scalable Firestore interactions.

Highlights

  • Multi-Database Support: Introduced a new FirestoreWithDatabase method to the App struct, enabling the creation of firestore.Client instances for specific named Cloud Firestore databases.
  • Enhanced Testing: Added comprehensive unit tests for the new FirestoreWithDatabase function, covering successful client creation and error handling for missing project IDs. New integration tests were also added to validate multi-database functionality, including concurrent operations on different databases.
  • Integration Test Refinements: Updated existing integration tests to utilize new test data structures and improved the TestServerTimestamp to correctly verify the type of server-generated timestamps.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Dec 4, 2025
View reviewed changes
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for multiple Cloud Firestore databases by adding a new FirestoreWithDatabase function. The implementation is accompanied by comprehensive unit and integration tests. My feedback focuses on improving code maintainability by addressing code duplication and enhancing the robustness of the integration tests to ensure proper resource cleanup.

@jonathanedey
Copy link
Collaborator Author

jonathanedey commented Dec 8, 2025

/gemini review

gemini-code-assist[bot]
gemini-code-assist bot reviewed Dec 8, 2025
View reviewed changes
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for multiple named databases in Cloud Firestore by adding a FirestoreWithDatabase method. The implementation maintains backward compatibility by having the existing Firestore method call the new one with the default database ID. The changes are well-tested with new unit and integration tests. My review includes a couple of suggestions for the new integration tests to improve maintainability and adhere to Go's testing best practices.

lahirumaramba
lahirumaramba requested changes Dec 9, 2025
View reviewed changes
Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Added a few comments.

integration/firestore/firestore_test.go
}
}

func TestFirestoreMultiDB(t *testing.T) {
Copy link
Member

@lahirumaramba lahirumaramba Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels repetitive. Doesn't TestFirestoreWithDatabaseID and TestFirestore cover this?

Copy link
Collaborator Author

@jonathanedey jonathanedey Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test in for verifying that two databases clients can be opened and modified at once with no impact on the other.

Copy link
Member

@lahirumaramba lahirumaramba Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. We can keep this, but as a clarification, to me this feels like we are trying to test the cloud firestore SDK here. This should be a more fitting test for the Firestore SDK and slightly beyond the Admin SDK scope. The Admin SDK should test the part where we are setting the database ID in the Firestore SDK and everything beyond that should be tested in the Firestore SDK itself (which I think they do).

lahirumaramba
lahirumaramba approved these changes Dec 10, 2025
View reviewed changes
Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM!
We should be good once we get a TW review.

integration/firestore/firestore_test.go
}
}

func TestFirestoreMultiDB(t *testing.T) {
Copy link
Member

@lahirumaramba lahirumaramba Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. We can keep this, but as a clarification, to me this feels like we are trying to test the cloud firestore SDK here. This should be a more fitting test for the Firestore SDK and slightly beyond the Admin SDK scope. The Admin SDK should test the part where we are setting the database ID in the Firestore SDK and everything beyond that should be tested in the Firestore SDK itself (which I think they do).

@jonathanedey @lahirumaramba
chore: Fix CONTRIBUTING.md typo
ed2bea1 
Co-authored-by: Lahiru Maramba <llahiru@gmail.com>
@jonathanedey jonathanedey merged commit 1fe3c70 into dev Jan 15, 2026
8 checks passed
@jonathanedey jonathanedey deleted the je-multi-fs branch January 15, 2026 16:37
@github-actions github-actions bot mentioned this pull request Jan 21, 2026
Merged
lahirumaramba added a commit that referenced this pull request Jan 21, 2026
@github-actions @jonathanedey @lahirumaramba
[chore] Release v4.19.0 (#747)
4f7026f 
* chore: Added and `AGENTS.md` file to instruct AI agents how to interact with this repository (#710)

* fix(auth): Fixed auth error code parsing (#712)

* fix(auth): Fixed auth error code parsing

* fix(auth): Fixed test to use error message prefix

* chore: update copyright headers from Google Inc. to Google LLC (#713)

* chore: Update github actions workflows and integration test resources (#740)

* chore: Pinned github actions to a full-length commit SHA

* chore: Update integration test resources

* chore: Added environment label to release action

* Trigger integration tests

* feat(firestore): Added Firestore Multi Database Support (#733)

* feat(firestore): Add Firestore Multi Database Support

* fix: Address gemini review

* fix: gemini review

* fix: Update name from API review

* fix: Address review comments

* chore: Fix CONTRIBUTING.md typo

Co-authored-by: Lahiru Maramba <llahiru@gmail.com>

---------

Co-authored-by: Lahiru Maramba <llahiru@gmail.com>

* feat(auth): Add `QueryUsers` API (#727)

This change implements the accounts:query functionality, providing a new QueryUsers method that allows searching for users with filters and sorting options.

RELEASE_NOTE: Added QueryUsers() API to support querying user accounts with filters, sorting, and pagination.

* Update the release actions process (#741)

This PR refactors the release automation to improve security by removing the direct merge from the workflow.

* [chore] Release 4.19.0 (#742)

* Revert "[chore] Release 4.19.0 (#742)" (#744)

This reverts commit 3a86709.

* chore: Update Release Workflows for Push triggers (#745)

* chore: Update release actions to run on Release env

* Trigger CI

* update the actions

* update the base_ref

* remove fetch-depth to prevent conflicts

* [chore] Release 4.19.0 Take 2 (#746)

---------

Co-authored-by: Jonathan Edey <145066863+jonathanedey@users.noreply.github.com>
Co-authored-by: Lahiru Maramba <llahiru@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lahirumaramba lahirumaramba lahirumaramba approved these changes

@markarndt markarndt markarndt approved these changes

@wu-hui wu-hui Awaiting requested review from wu-hui

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release:stage Stage a release candidate release-note

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jonathanedey @lahirumaramba @markarndt