Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/apptesting/invokeTests.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
.post(
`/v1alpha/projects/${projectNumber}/apps/${appId}/testInvocations:invokeTestCases`,
(r) => {
requestBody = r;

Check warning on line 39 in src/apptesting/invokeTests.spec.ts

View workflow job for this annotation

GitHub Actions / lint (20)

Unsafe assignment of an `any` value
return true;
},
)
Expand All @@ -55,7 +55,7 @@
testCase: {
startUri: "https://www.example.com",
displayName: "testName2",
steps: [{ goal: "retest it", successCriteria: "a dialog appears" }],
steps: [{ goal: "retest it", finalScreenAssertion: "a dialog appears" }],
},
testExecution: [{ config: { browser: Browser.CHROME } }],
},
Expand Down Expand Up @@ -89,7 +89,7 @@
steps: [
{
goal: "retest it",
successCriteria: "a dialog appears",
finalScreenAssertion: "a dialog appears",
},
],
startUri: "https://www.example.com",
Expand Down Expand Up @@ -125,11 +125,11 @@
});

it("calls poll callback with metadata on each poll", async () => {
const pollResponses: { [k: string]: any }[] = [];

Check warning on line 128 in src/apptesting/invokeTests.spec.ts

View workflow job for this annotation

GitHub Actions / lint (20)

Unexpected any. Specify a different type
await pollInvocationStatus(
operationName,
(op) => {
pollResponses.push(op.metadata!);

Check warning on line 132 in src/apptesting/invokeTests.spec.ts

View workflow job for this annotation

GitHub Actions / lint (20)

Forbidden non-null assertion
},
/* backoff= */ 1,
);
Expand Down
2 changes: 1 addition & 1 deletion src/apptesting/parseTestFiles.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
rmSync(tempdir.name, { recursive: true });
});

function writeFile(filename: string, content: string) {

Check warning on line 23 in src/apptesting/parseTestFiles.spec.ts

View workflow job for this annotation

GitHub Actions / lint (20)

Missing return type on function
const file = join(tempdir.name, filename);
fs.writeFileSync(file, content);
}
Expand Down Expand Up @@ -82,7 +82,7 @@
{
goal: "View the provided application",
hint: "No additional actions should be necessary",
successCriteria: "The application should load with no obvious errors",
finalScreenAssertion: "The application should load with no obvious errors",
},
],
},
Expand Down Expand Up @@ -161,7 +161,7 @@
});

describe("filtering", () => {
function createBasicTest(displayNames: string[]) {

Check warning on line 164 in src/apptesting/parseTestFiles.spec.ts

View workflow job for this annotation

GitHub Actions / lint (20)

Missing return type on function
return stringify({
tests: displayNames.map((displayName) => ({
displayName,
Expand All @@ -170,7 +170,7 @@
});
}

async function getTestCaseNames(filenameFilter = "", testCaseFilter = "") {

Check warning on line 173 in src/apptesting/parseTestFiles.spec.ts

View workflow job for this annotation

GitHub Actions / lint (20)

Missing return type on function
const tests = await parseTestFiles(
tempdir.name,
"https://www.foo.com",
Expand Down
2 changes: 1 addition & 1 deletion src/apptesting/types.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
export interface TestStep {
goal: string;
successCriteria?: string;
finalScreenAssertion?: string;
hint?: string;
}

Expand Down
2 changes: 1 addition & 1 deletion templates/init/apptesting/smoke_test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ tests:
steps:
- goal: View the provided application
hint: No additional actions should be necessary
successCriteria: The application should load with no obvious errors
finalScreenAssertion: The application should load with no obvious errors
Loading