Skip to content

Sidebar category breakdown behaves oddly when looking at allocation call trees #5331

Description

@mstange

Profile: https://share.firefox.dev/4ao9Kgn

When dragging a selection and watching the category breakdown in the sidebar, sometimes the values stop updating.

Or if you zoom in: https://share.firefox.dev/4g4zM9N
Here the category breakdown has a lot of blue in it even though it should only have green.

I think this is because of the issue I pointed out in #5330. Every time we create an allocations-related SamplesLikeTable, we make a completely new table whose sample indexes have nothing to do with the unfiltered table. Translating between them using an index offset is not possible.

In this profile, the native-retained-allocations table for the unfiltered thread has 200 entries. But if you make a preview selection which starts at the beginning but which doesn't contain the deallocations at the end, the native-retained-allocations table for the preview filtered thread has 400 entries!

┆Issue is synchronized with this Jira Task

Metadata

Metadata

Assignees

Labels

allocationsIssues related to the JS or native allocation featureprofile dataIssues related to the profile format, data structure, or profile upgraderstimelineIssues related to the header timeline view

Type

Priority

None yet

Severity

None yet

Jira

None yet

Estimate

None yet

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions