Reduce confusion between call tree summary strategy aware samples and regular samples#5330
Conversation
mstange
force-pushed
the
ctss-sample-offset
branch
from
8821403 to
7c6ff51
Compare
|
Also, I think the sample offsets aren't even correct for the allocation strategies: The filtered allocation samples are computed from the range filtered thread, rather than by range filtering the allocation samples of the unfiltered thread. I haven't understood the difference in meaning between |
julienw
left a comment
julienw
left a comment
There was a problem hiding this comment.
I didn't look too closely at the changes, but this makes sense to me, thanks for the cleanup
There's no such things as a And as a result I think that we don't have a single function that filters everything in a thread using the range. |
Sorry yes, that function doesn't exist, but my point stands - when the call tree summary strategy is |
… summary strategy"-aware samples. Not a huge fan of the name "CtssSamples" but at least it's now different. This patch makes it obvious we have a few bugs.
mstange
force-pushed
the
ctss-sample-offset
branch
from
7c6ff51 to
1edbe67
Compare
Updates: [Julien Wajsberg] Some more small refactorings (#5320) [Markus Stange] Pass the correct sample index offset to getTimingsForCallNodeIndex for the flame graph tooltip. (#5328) [Nisarg Jhaveri] Update docs to include Android Studio/Simpleperf trace file support (#5309) [Markus Stange] Don't pass the preview filtered thread to getTimingsForPath/CallNodeIndex. (#5329) [Nazım Can Altınova] Add a "Sample timestamp" field to the sample tooltip in timeline (#5322) [Markus Stange] Reduce confusion between call tree summary strategy aware samples and regular samples (#5330) [Markus Stange] Rename this getCounter selector to getCounters. (#5337) [Markus Stange] Make sample indexes compatible between the unfiltered and (preview) filtered call tree summary strategy samples when using an allocation strat> [Markus Stange] Remove some code that uses the preview filtered thread (#5336) [Markus Stange] Remove getMarkerSchemaName special cases - look up marker schemas from data.type and nothing else (#5293) [Markus Stange] Remove the makeProfileSerializable step - make the raw in-memory profile match the format that's stored in the file (#5287) [Nicolas Chevobbe] Adapt FilterNavigatorBar to High Contrast Mode. (#5257) [Nicolas Chevobbe] Adapt Tracks to High Contrast Mode. (#5252) [Markus Stange] Adjust string index fields in markers when merging threads (#5344) [Theodoros Nikolaou] Localize title and aria label in ProfileName (#5345) [Julien Wajsberg] Adapt time-slice selection in High Contrast Mode. (#5259) [Markus Stange] Make stackTable (sub)category derived data (#5342) [Markus Stange] Compute cpuRatio values when computing the derived thread (#5288) [Nazım Can Altınova] Add a context menu item to open the JS scripts in DevTools debugger (#5295) Also thanks to our localizers: el: Jim Spentzos fr: Théo Chevalier it: Francesco Lodolo [:flod] zh-TW: Pin-guang Chen
2 participants
Fixes #5326, but leaves #5327 unfixed for now.