Remove User-Agent header again.#3685
Merged
Merged
Conversation
The addition of this header triggers the browser to send an OPTIONS request with a CORS preflight request. profiler-symbol-server doesn't currently know how to deal with this, so symbolication with profiler-symbol-server is broken. This works around it.
Contributor
|
Ah, I indeed thought of that during the evening, but confusingly thought we were already doing preflight cors requests before (I wanted to check today). Thanks for the quick revert! |
Contributor
Author
|
I fixed the server in mstange/profiler-symbol-server@2ac9ed9 and made new releases of profiler-symbol-server and perfrecord. We could add the User-Agent header back now. |
Contributor
Author
|
I'm re-adding the UA header in #5103. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts the last-minute change I made in #3677.
The addition of the User-Agent header triggers the browser to send an
OPTIONSrequest with a CORS preflight request.profiler-symbol-serverdoesn't currently know how to deal with this, so symbolication with profiler-symbol-server is broken.This works around it.